Skip to content

Job sequencing with deadlines - #6854

Merged
cclauss merged 18 commits into
TheAlgorithms:masterfrom
lakshayroop5:Job_Sequencing_with_Deadlines
Oct 9, 2022
Merged

Job sequencing with deadlines#6854
cclauss merged 18 commits into
TheAlgorithms:masterfrom
lakshayroop5:Job_Sequencing_with_Deadlines

Conversation

@lakshayroop5

@lakshayroop5 lakshayroop5 commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

Describe your change:

In this PR, I have written an optimized algorithm for the issue "Job Sequencing with Deadlines". This problem required a greedy approach so I have created a new python file "job_sequencing_with_deadlines" in the "greedy_methods" directory.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 9, 2022
@cclauss

cclauss commented Oct 9, 2022

Copy link
Copy Markdown
Member

Click Details next to the failing tests below to see:

greedy_methods/job_sequencing_with_deadline.py:10:1: E302 expected 2 blank lines, found 1
greedy_methods/job_sequencing_with_deadline.py:23:89: E501 line too long (90 > 88 characters)
greedy_methods/job_sequencing_with_deadline.py:25:89: E501 line too long (103 > 88 characters)

cclauss
cclauss reviewed Oct 9, 2022
View reviewed changes
Comment thread greedy_methods/job_sequencing_with_deadline.py Outdated
"""
This is a pure Python implementation of the greedy-merge-sort algorithm

<<<<<<< HEAD

@cclauss cclauss Oct 9, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a Python syntax error.

lakshayroop5
lakshayroop5 commented Oct 9, 2022
View reviewed changes

@lakshayroop5 lakshayroop5 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected code

lakshayroop5
lakshayroop5 commented Oct 9, 2022
View reviewed changes

@lakshayroop5 lakshayroop5 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected spacing issue

lakshayroop5
lakshayroop5 commented Oct 9, 2022
View reviewed changes

@lakshayroop5 lakshayroop5 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected spacing issue

@lakshayroop5

lakshayroop5 commented Oct 9, 2022

Copy link
Copy Markdown
Contributor Author

I hope the algorithm written in this PR solves the given problem optimally and accurately. Kindly review my PR as soon as possible and suggest any necessary changes if required.
Thank you

cclauss
cclauss reviewed Oct 9, 2022
View reviewed changes
Comment thread greedy_methods/job_sequencing_with_deadline.py Outdated
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Oct 9, 2022
lakshayroop5
lakshayroop5 commented Oct 9, 2022
View reviewed changes

@lakshayroop5 lakshayroop5 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated reviews

@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Oct 9, 2022
cclauss
cclauss approved these changes Oct 9, 2022
View reviewed changes

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to scheduling

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 9, 2022
@cclauss
cclauss merged commit 51dba4d into TheAlgorithms:master Oct 9, 2022
@lakshayroop5
lakshayroop5 deleted the Job_Sequencing_with_Deadlines branch October 9, 2022 13:42
Subhajit-Roy-O1 added a commit to Subhajit-Roy-O1/Python that referenced this pull request Oct 10, 2022
@Subhajit-Roy-O1
Merge pull request #1 from TheAlgorithms/master
35bb951 
Job sequencing with deadlines (TheAlgorithms#6854)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lakshayroop5 @cclauss @lavenroop5