Skip to content

lorenz -> lorentz#6670

Merged
cclauss merged 1 commit intoTheAlgorithms:masterfrom
rohanr18:patch-5
Oct 4, 2022
Merged

lorenz -> lorentz#6670
cclauss merged 1 commit intoTheAlgorithms:masterfrom
rohanr18:patch-5

Conversation

@rohanr18
Copy link
Copy Markdown
Contributor

@rohanr18 rohanr18 commented Oct 4, 2022 •
edited
Loading

Describe your change:

correct spelling according to: https://en.wikipedia.org/wiki/Lorentz_transformation

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss merged commit 087a3a8 into TheAlgorithms:master Oct 4, 2022
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Oct 4, 2022

Please add the URL https://en.wikipedia.org/wiki/Lorentz_transformation to the docstring in a separate PR.

@rohanr18
Copy link
Copy Markdown
Contributor Author

rohanr18 commented Oct 4, 2022

It's already there, somewhere at the bottom.

@rohanr18 rohanr18 deleted the patch-5 branch October 4, 2022 19:58
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Oct 4, 2022

I was thinking that they could not spell it wrong if they included the wiki URL.

@rohanr18
Copy link
Copy Markdown
Contributor Author

rohanr18 commented Oct 4, 2022

fair enough

@rohanr18
Copy link
Copy Markdown
Contributor Author

rohanr18 commented Oct 4, 2022

while I have you, do you mind having a quick look at #6441 and #6442?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rohanr18 @cclauss