Skip to content

Add surface area of cuboid, conical frustum#6442

Merged
cclauss merged 3 commits intoTheAlgorithms:masterfrom
rohanr18:patch-4
Oct 12, 2022
Merged

Add surface area of cuboid, conical frustum#6442
cclauss merged 3 commits intoTheAlgorithms:masterfrom
rohanr18:patch-4

Conversation

@rohanr18
Copy link
Copy Markdown
Contributor

@rohanr18 rohanr18 commented Oct 1, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@rohanr18 rohanr18 requested a review from Kush1101 as a code owner October 1, 2022 08:34
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 1, 2022
@algorithms-keeper algorithms-keeper bot mentioned this pull request Oct 3, 2022
Closed
14 tasks
@rohanr18 rohanr18 mentioned this pull request Oct 4, 2022
Merged
14 tasks
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Oct 5, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Oct 5, 2022
@rohanr18
Copy link
Copy Markdown
Contributor Author

rohanr18 commented Oct 12, 2022

@cclauss Please review this one too 🙏

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 12, 2022
@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 12, 2022
@cclauss cclauss merged commit 467ade2 into TheAlgorithms:master Oct 12, 2022
@rohanr18 rohanr18 deleted the patch-4 branch October 12, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

@CaedenPH CaedenPH CaedenPH approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

enhancement This PR modified some existing files hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohanr18 @cclauss @CaedenPH