Merged
Conversation
itsamirhn
approved these changes
Aug 17, 2022
Contributor
Author
|
@cclauss can you please take a look |
poyea
approved these changes
Sep 14, 2022
Member
poyea
left a comment
There was a problem hiding this comment.
Thank you for your pull request!🤩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
And test for bugs in Max Fenwick Tree and modifications to fix them.
Using 1-based-indexing operations:
(index | (index + 1))for a 0-based fenwick tree requires handling edge cases and is the cause for the bugs. Replacing with 0-based-indexing operations.Checklist:
Fixes: #{$ISSUE_NO}.