Skip to content

Add Max Fenwick Tree - #6298

Merged
cclauss merged 11 commits into
TheAlgorithms:masterfrom
itsamirhn:max-fenwick-tree
Aug 12, 2022
Merged

Add Max Fenwick Tree#6298
cclauss merged 11 commits into
TheAlgorithms:masterfrom
itsamirhn:max-fenwick-tree

Conversation

@itsamirhn

@itsamirhn itsamirhn commented Aug 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Describe your change:

I created MaxFenwickTreeOneBasedIndexing wich solves this problem:

  • Update A[i] = value
  • Query Maximum of Range (l, r]

This algorithm use classic fenwick tree with some changes in key ideas.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added require descriptive names This PR needs descriptive function and/or variable names require type hints https://docs.python.org/3/library/typing.html labels Aug 6, 2022
ghost
ghost reviewed Aug 6, 2022
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread data_structures/binary_tree/maximum_fenwick_tree.py Outdated
Comment thread data_structures/binary_tree/maximum_fenwick_tree.py Outdated
Comment thread data_structures/binary_tree/maximum_fenwick_tree.py Outdated
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Aug 6, 2022
@ghost ghost removed the require type hints https://docs.python.org/3/library/typing.html label Aug 6, 2022
ghost
ghost reviewed Aug 6, 2022
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread data_structures/binary_tree/maximum_fenwick_tree.py Outdated
@ghost ghost removed the require descriptive names This PR needs descriptive function and/or variable names label Aug 6, 2022
cclauss
cclauss reviewed Aug 6, 2022
View reviewed changes
Comment thread data_structures/binary_tree/maximum_fenwick_tree.py Outdated
cclauss
cclauss reviewed Aug 6, 2022
View reviewed changes
Comment thread data_structures/binary_tree/maximum_fenwick_tree.py Outdated
cclauss
cclauss reviewed Aug 6, 2022
View reviewed changes
Comment thread data_structures/binary_tree/maximum_fenwick_tree.py Outdated
@itsamirhn
Complete docstring
4ee19a4
@itsamirhn
Complete docstring
9a05803
@itsamirhn
Merge remote-tracking branch 'origin/max-fenwick-tree' into max-fenwi…
72aa12e 
…ck-tree

# Conflicts:
#	data_structures/binary_tree/maximum_fenwick_tree_one_based_indexig.py
@itsamirhn

itsamirhn commented Aug 6, 2022

Copy link
Copy Markdown
Member Author

@cclauss Let me now if these changes solves the issues that you commented.

@itsamirhn itsamirhn changed the title Add MaxFenwickTree Add MaxFenwickTreeOneBasedIndexing Aug 6, 2022
@cclauss

cclauss commented Aug 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Why is one-based indexing an advantage in a language that uses zero-based indexing?

@itsamirhn

itsamirhn commented Aug 8, 2022

Copy link
Copy Markdown
Member Author

The one-based indexing is default for any Fenwick Tree. In all languages we use one-based indexing because of the main theory idea behind Fenwick tree that is i & (-i) will not work for Zero and in every method we have to check for this case.

Even in the previous implementation of Fenwick Tree in this repository (here), we had to used one-based by default.

But there is another tricky way to solve the one-based indexing issue as Wikipedia has used too.

I can add the zero-based indexing too if you want.

@itsamirhn itsamirhn changed the title Add MaxFenwickTreeOneBasedIndexing Add Max Fenwick Tree Aug 12, 2022
@itsamirhn

itsamirhn commented Aug 12, 2022

Copy link
Copy Markdown
Member Author

@cclauss, I changed the tree into 0-based indexing.

@ghost ghost mentioned this pull request Aug 12, 2022
Closed
14 tasks
cclauss
cclauss approved these changes Aug 12, 2022
View reviewed changes

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Aug 12, 2022
@cclauss
cclauss merged commit f46ce47 into TheAlgorithms:master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@itsamirhn @cclauss