Improve Project Euler problem 145 solution 1#6259
Merged
dhruvmanila merged 5 commits intoTheAlgorithms:masterfrom Jul 23, 2022
Merged
Conversation
…//github.com/MaximSmolskiy/Python into improve-project-euler-problem-145-solution-1
dhruvmanila
reviewed
Jul 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Improve Project Euler problem 145 solution 1 - the top 1 slowest solution on GitHub Actions logs (under
slowest 10 durations:803.76s call scripts/validate_solutions.py::test_project_euler[problem_145/sol1.py]):Improve solution (~30 times - from 900+ seconds to ~30 seconds)
Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?
Checklist:
Fixes: #{$ISSUE_NO}.