Skip to content

fix: test failures#6250

Merged
dhruvmanila merged 1 commit intoTheAlgorithms:masterfrom
dhruvmanila:fix/assert-error
Jul 14, 2022
Merged

fix: test failures#6250
dhruvmanila merged 1 commit intoTheAlgorithms:masterfrom
dhruvmanila:fix/assert-error

Conversation

@dhruvmanila
Copy link
Copy Markdown
Member

@dhruvmanila dhruvmanila commented Jul 14, 2022

  1. Incorrect function was being imported from the module
  2. Testing for exception was not done correctly

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@dhruvmanila dhruvmanila requested a review from Kush1101 as a code owner July 14, 2022 04:41
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 14, 2022
@dhruvmanila dhruvmanila requested review from cclauss and removed request for Kush1101 July 14, 2022 04:41
@ghost ghost added the tests are failing Do not merge until tests pass label Jul 14, 2022
@dhruvmanila
fix: test failures
2dc38d5 
1. Incorrect function was being imported from the module
2. Testing for exception was not done correctly
@ghost ghost removed the tests are failing Do not merge until tests pass label Jul 14, 2022
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jul 14, 2022
@dhruvmanila dhruvmanila merged commit 38dfcd2 into TheAlgorithms:master Jul 14, 2022
@dhruvmanila dhruvmanila deleted the fix/assert-error branch July 14, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

bugfix enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhruvmanila @cclauss