Skip to content

fixed mypy annotations for arithmetic_analysis#6040

Merged
poyea merged 3 commits intoTheAlgorithms:masterfrom
Leoriem-code:mypy-annotations-arithmetic_analysis
May 12, 2022
Merged

fixed mypy annotations for arithmetic_analysis#6040
poyea merged 3 commits intoTheAlgorithms:masterfrom
Leoriem-code:mypy-annotations-arithmetic_analysis

Conversation

@Leoriem-code
Copy link
Copy Markdown
Contributor

@Leoriem-code Leoriem-code commented Mar 9, 2022 •
edited
Loading

Describe your change:

Updated mypy annotations

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Mar 9, 2022
@stale
Copy link
Copy Markdown

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Apr 16, 2022
@stale stale bot removed the stale Used to mark an issue or pull request stale. label Apr 16, 2022
poyea
poyea approved these changes May 12, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label May 12, 2022
@poyea poyea merged commit 533eea5 into TheAlgorithms:master May 12, 2022
@Leoriem-code Leoriem-code deleted the mypy-annotations-arithmetic_analysis branch May 12, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Leoriem-code @poyea