Skip to content

Update basic_maths.py#6017

Merged
poyea merged 1 commit intoTheAlgorithms:masterfrom
nivid26:master
Jun 22, 2022
Merged

Update basic_maths.py#6017
poyea merged 1 commit intoTheAlgorithms:masterfrom
nivid26:master

Conversation

@nivid26
Copy link
Copy Markdown
Contributor

@nivid26 nivid26 commented Feb 23, 2022

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@nivid26 nivid26 requested a review from Kush1101 as a code owner February 23, 2022 17:41
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Feb 23, 2022
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Feb 28, 2022

Please add a test that fails under the current code but passes under the new code so we have proof that this change is really needed.

@nivid26
Copy link
Copy Markdown
Contributor Author

nivid26 commented Mar 1, 2022

Old Code:
number_of_divisors(6) return 2 but actually number of divisor of 6 is 4(1,2,3,6).
New Code:
number_of_divisors(6) return 4 which right answer.

@stale
Copy link
Copy Markdown

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Apr 16, 2022
poyea
poyea reviewed May 12, 2022
View reviewed changes
@stale stale bot removed the stale Used to mark an issue or pull request stale. label May 12, 2022
@stale
Copy link
Copy Markdown

stale bot commented Jun 12, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Jun 12, 2022
@poyea
Copy link
Copy Markdown
Member

poyea commented Jun 12, 2022

@nivid26 This actually looks correct. Would you be able to add a few tests to cover this?

@stale stale bot removed the stale Used to mark an issue or pull request stale. label Jun 12, 2022
@nivid26
Copy link
Copy Markdown
Contributor Author

nivid26 commented Jun 14, 2022 •
edited
Loading

In the following files, few significant included where previous version of basic_maths.py is failed compute correct result of code and also included the correct output generated by modified version.
testCases.xlsx

poyea
poyea approved these changes Jun 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Jun 22, 2022
@poyea poyea merged commit 42a80cd into TheAlgorithms:master Jun 22, 2022
@Bjiornulf Bjiornulf mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nivid26 @cclauss @poyea