Skip to content

[mypy] Fix type annotations in wavelet_tree.py#5641

Merged
l3str4nge merged 2 commits intoTheAlgorithms:masterfrom
dylanbuchi:mypy-fix-wavelet-tree
Oct 28, 2021
Merged

[mypy] Fix type annotations in wavelet_tree.py#5641
l3str4nge merged 2 commits intoTheAlgorithms:masterfrom
dylanbuchi:mypy-fix-wavelet-tree

Conversation

@dylanbuchi
Copy link
Copy Markdown
Contributor

@dylanbuchi dylanbuchi commented Oct 28, 2021 •
edited
Loading

Describe your change:

Fix type annotations and a typo in data_structures/binary_tree/wavelet_tree.py

Related issue: #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 28, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 28, 2021
l3str4nge
l3str4nge requested changes Oct 28, 2021
View reviewed changes
@ghost ghost added the awaiting changes A maintainer has requested changes to this PR label Oct 28, 2021
@ghost ghost removed the awaiting changes A maintainer has requested changes to this PR label Oct 28, 2021
@l3str4nge l3str4nge merged commit 0590d73 into TheAlgorithms:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dylanbuchi @l3str4nge