Skip to content

[mypy] Adds type annotations in other/activity_selection #4052#5590

Merged
cclauss merged 1 commit intoTheAlgorithms:masterfrom
spazm:mypy-fix-other-activity_selection
Oct 26, 2021
Merged

[mypy] Adds type annotations in other/activity_selection #4052#5590
cclauss merged 1 commit intoTheAlgorithms:masterfrom
spazm:mypy-fix-other-activity_selection

Conversation

@spazm
Copy link
Copy Markdown
Contributor

@spazm spazm commented Oct 25, 2021 •
edited
Loading

Describe your change:

Adds type annotations to the parameters of printMaxActivites

See #4052

Before

% git checkout master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

% mypy  --disallow-untyped-defs --disallow-untyped-calls other/activity_selection.py
other/activity_selection.py:13: error: Function is missing a type annotation
other/activity_selection.py:46: error: Call to untyped function "printMaxActivities" in typed context
Found 2 errors in 1 file (checked 1 source file)

After

% git checkout -
Switched to branch 'mypy-fix-other-activity_selection'

% mypy --strict other/activity_selection.py
Success: no issues found in 1 source file
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 25, 2021
@spazm spazm force-pushed the mypy-fix-other-activity_selection branch from ea6d651 to c6c2c34 Compare October 25, 2021 09:01
cclauss
cclauss reviewed Oct 26, 2021
View reviewed changes
other/activity_selection.py


def printMaxActivities(start, finish):
def printMaxActivities(start: list[int], finish: list[int]) -> None:
Copy link
Copy Markdown
Member

@cclauss cclauss Oct 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ever use https://docs.python.org/3/library/typing.html#typing.Iterable to declare that we are willing to accept data from a list, a tuple, a generator, or anything else that implements .__iter__()?

cclauss
cclauss approved these changes Oct 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 26, 2021
@cclauss cclauss merged commit de07245 into TheAlgorithms:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spazm @cclauss