Update pop function#5544
Merged
cclauss merged 8 commits intoTheAlgorithms:masterfrom Oct 23, 2021
limbad-YK:master
Merged
Conversation
Added underflow condition
Added condition to check underflow of stack
ghost
added
awaiting reviews
cclauss
reviewed
Oct 23, 2021
data_structures/stacks/stack.py
Outdated
|
|
||
| def pop(self): | ||
| """Pop an element off of the top of the stack.""" | ||
| if not self.stack: # Condition to check Underflow of stack |
Member
There was a problem hiding this comment.
Suggested change
| if not self.stack: # Condition to check Underflow of stack | |
| if not self.stack: # Condition to check Underflow of stack |
cclauss
reviewed
Oct 23, 2021
| @@ -64,6 +68,7 @@ def test_stack() -> None: | |||
| assert stack.is_full() is False | |||
| assert str(stack) == "[]" | |||
Member
There was a problem hiding this comment.
Suggested change
| assert str(stack) == "[]" | |
| assert stack == [] |
spartan289
approved these changes
Oct 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.