Skip to content

Make decrypt_caesar_with_chi_squared work with upper case letters#5379

Merged
l3str4nge merged 2 commits intoTheAlgorithms:masterfrom
happiestbee:Fixes--#5323
Oct 31, 2021
Merged

Make decrypt_caesar_with_chi_squared work with upper case letters#5379
l3str4nge merged 2 commits intoTheAlgorithms:masterfrom
happiestbee:Fixes--#5323

Conversation

@happiestbee
Copy link
Copy Markdown
Contributor

@happiestbee happiestbee commented Oct 17, 2021

Fixed case sensitive not working in decrypt_casear_with_chi_squared.py

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 17, 2021
@poyea poyea changed the title Fixes: #5323 Make decrypt_caesar_with_chi_squared work with upper case letters Oct 18, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 18, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 19, 2021
@happiestbee
Copy link
Copy Markdown
Contributor Author

happiestbee commented Oct 28, 2021

I would like to request a review for this pr

l3str4nge
l3str4nge approved these changes Oct 31, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@l3str4nge l3str4nge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 31, 2021
@l3str4nge l3str4nge merged commit f4fd147 into TheAlgorithms:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@happiestbee @l3str4nge