added complete graph generator function#5239
Closed
manueldilullo wants to merge 6 commits intoTheAlgorithms:masterfrom
Closed
added complete graph generator function#5239manueldilullo wants to merge 6 commits intoTheAlgorithms:masterfrom
manueldilullo wants to merge 6 commits intoTheAlgorithms:masterfrom
Conversation
ghost
added
awaiting reviews
ghost
reviewed
Oct 11, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
graphs/complete_graph_generator.py
Outdated
| * Description: Complete graphs generator. Uses graphs represented with an adjacency list | ||
| """ | ||
|
|
||
| def complete_graph(n): |
There was a problem hiding this comment.
Please provide return type hint for the function: complete_graph. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: n
Please provide descriptive name for the parameter: n
ghost
reviewed
Oct 11, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
graphs/complete_graph_generator.py
Outdated
| URL: https://en.wikipedia.org/wiki/Complete_graph | ||
| """ | ||
|
|
||
| def complete_graph(n:int): |
There was a problem hiding this comment.
Please provide return type hint for the function: complete_graph. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: n
ghost
removed
the
require type hints
ghost
reviewed
Oct 11, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
graphs/complete_graph_generator.py
Outdated
| URL: https://en.wikipedia.org/wiki/Complete_graph | ||
| """ | ||
|
|
||
| def complete_graph(n:int) -> dict: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
ghost
added
tests are failing
Member
|
A duplicate of #5240 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.