Skip to content

Added solution for Project Euler problem 145#5173

Merged
poyea merged 8 commits intoTheAlgorithms:masterfrom
chakeson:master
Nov 10, 2021
Merged

Added solution for Project Euler problem 145#5173
poyea merged 8 commits intoTheAlgorithms:masterfrom
chakeson:master

Conversation

@chakeson
Copy link
Copy Markdown
Contributor

@chakeson chakeson commented Oct 9, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 9, 2021
@ghost ghost added the tests are failing Do not merge until tests pass label Oct 19, 2021
@chakeson
Copy link
Copy Markdown
Contributor Author

chakeson commented Oct 20, 2021

Fixed all the tests that failed, can you run the workflows again?

@poyea
Copy link
Copy Markdown
Member

poyea commented Oct 21, 2021

Please see and wait for #5496.

@chakeson
Copy link
Copy Markdown
Contributor Author

chakeson commented Oct 25, 2021

@poyea can you rerun workflows, since euler tests seem to be fixed.

poyea
poyea reviewed Oct 26, 2021
View reviewed changes
chakeson and others added 3 commits October 26, 2021 15:22
@chakeson @poyea
nr -> number
8c21139 
Co-authored-by: John Law <johnlaw.po@gmail.com>
@chakeson
nr -> number
d407d55
@poyea
Update sol1.py
59f7001
@ghost ghost added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Nov 7, 2021
poyea
poyea approved these changes Nov 10, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 10, 2021
@poyea poyea merged commit d6a1623 into TheAlgorithms:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chakeson @poyea