Improved readability of web_programming/get_imdbtop.py and added documentations with doctests - #4855
Merged
Merged
Conversation
added 2 commits
October 1, 2021 23:53
…ocumentations with doctests.
…ocumentations with doctests.
ghost
added
awaiting reviews
cclauss
reviewed
Oct 1, 2021
cclauss
reviewed
Oct 1, 2021
cclauss
reviewed
Oct 2, 2021
| """ | ||
| print(f"Crawling {num_movies} movies from the IMDB databse ...") | ||
|
|
||
| print(f"Crawling {num_movies} movies from the IMDB database...") |
Member
There was a problem hiding this comment.
Move print() outside the algorithmic function.
cclauss
reviewed
Oct 2, 2021
…ests as suggested
Member
|
mypy found problems on lines 26, 46, and 47 |
Author
I think I have fixed this, by running mypy locally |
Author
|
@poyea Could you kindly review this one? |
cclauss
approved these changes
Oct 16, 2021
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
…mentations with doctests (TheAlgorithms#4855) * improved readability of the existing method by reformatting, adding documentations with doctests. * improved readability of the existing method by reformatting, adding documentations with doctests. * fixed typo in test * added doctest to parse dictionary method * added doctest to parse dictionary method * Changed return type, removed print() from method and implemented doctests as suggested * Fixed doctest error, removed print() from method, created new script as suggested * Update get_imdbtop.py * Fix typo discovered by codespell * return () Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated an existing script
web_programming/get_imdbtop.pyto crawl top n movies from the imdb databse based on ratings. It includesdocumentationsanddoctests. Modularized the script and made it more customizable. Fixed formatting usingblackandflake8.Checklist:
Fixes: #{$ISSUE_NO}.