Download images from google query - #4853
Merged
cclauss merged 12 commits intoOct 16, 2021
Merged
Conversation
ghost
added
awaiting reviews
Author
|
@cclauss any review for this one? |
Author
|
@poyea can i get a review on this? I had mistakenly pushed another PR without checking the boxes, which got marked as |
Member
|
I'd suggest this go into |
cclauss
requested changes
Oct 15, 2021
cclauss
left a comment
cclauss
left a comment
Member
There was a problem hiding this comment.
This is starting to look great!
ghost
added
awaiting changes
using iterators instead of lists Co-authored-by: Christian Clauss <cclauss@me.com>
ghost
added
awaiting reviews
Improve readability by removing one-time used variable Co-authored-by: Christian Clauss <cclauss@me.com>
Decreasing complication through standard practices. Co-authored-by: Christian Clauss <cclauss@me.com>
Exception Handling Co-authored-by: Christian Clauss <cclauss@me.com>
Author
cclauss
reviewed
Oct 15, 2021
| @@ -0,0 +1,42 @@ | |||
| import sys | |||
Member
There was a problem hiding this comment.
On my Mac, when I run python3 -m doctest -v web_programming/show_image_tab_from_google_query.py the tests fail. What happens on your computer?
cclauss
approved these changes
Oct 16, 2021
cclauss
changed the title
Author
|
@cclauss Thank you very much. I have honestly learned the most while trying to get PRs accepted into this repo. And I really appreciate you for taking the time to monitor and help us, beginner contributors!! You have been an amazing teacher 😄 |
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
* Added new script to open the google image tab with a search query. * Added new script to open the google image tab with a search query. * Added new script to open the google image tab with a search query with doctests. * Fixed doctest error, removed print() from method, changed return type * Update web_programming/show_image_tab_from_google_query.py using iterators instead of lists Co-authored-by: Christian Clauss <cclauss@me.com> * Update web_programming/show_image_tab_from_google_query.py Improve readability by removing one-time used variable Co-authored-by: Christian Clauss <cclauss@me.com> * Update web_programming/show_image_tab_from_google_query.py Decreasing complication through standard practices. Co-authored-by: Christian Clauss <cclauss@me.com> * Update web_programming/show_image_tab_from_google_query.py Exception Handling Co-authored-by: Christian Clauss <cclauss@me.com> * changed complete method to download images from google search query * Update download_images_from_google_query.py * Delete show_image_tab_from_google_query.py Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new script
web_programming/show_image_tab_from_google_query.pyto open the google image tab with a search query. It includesdocumentationsanddoctests. Modularized the script and made it more customizable. Fixed formatting usingblackandflake8.Checklist:
Fixes: #{$ISSUE_NO}.