Skip to content

[mypy] Added type annotations to disjoint_set.py#4814

Merged
poyea merged 1 commit intoTheAlgorithms:masterfrom
scfenton6:mypy-fix
Oct 11, 2021
Merged

[mypy] Added type annotations to disjoint_set.py#4814
poyea merged 1 commit intoTheAlgorithms:masterfrom
scfenton6:mypy-fix

Conversation

@scfenton6
Copy link
Copy Markdown
Contributor

@scfenton6 scfenton6 commented Oct 1, 2021 •
edited
Loading

Added type annotations in the program disjoint_set.py, located in the data_structures/disjoint_set folder. I also capitalized some words in the docstring and comments.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 1, 2021
poyea
poyea approved these changes Oct 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 11, 2021
@poyea poyea merged commit abaa0d7 into TheAlgorithms:master Oct 11, 2021
@scfenton6 scfenton6 deleted the mypy-fix branch October 12, 2021 10:09
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@scfenton6 @shermanhui
Add type annotations (TheAlgorithms#4814)
48646fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scfenton6 @poyea