Skip to content

Mypy Fix type annotations for a1z26, enigma_machine2, trafid_cipher and xor_cipher from ciphers#4761

Closed
avivfaraj wants to merge 28 commits intoTheAlgorithms:masterfrom
avivfaraj:mypy-fix
Closed

Mypy Fix type annotations for a1z26, enigma_machine2, trafid_cipher and xor_cipher from ciphers#4761
avivfaraj wants to merge 28 commits intoTheAlgorithms:masterfrom
avivfaraj:mypy-fix

Conversation

@avivfaraj
Copy link
Copy Markdown
Contributor

@avivfaraj avivfaraj commented Sep 14, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • [] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

avivfaraj and others added 27 commits September 3, 2021 19:47
@avivfaraj
Add files via upload
a565258
@avivfaraj
Changed print to f-string
4951686 
Also printed out results in a math notation
@avivfaraj
Add files via upload
ff2a162
@avivfaraj
Fixes: #4710 provided return type
6550183
@avivfaraj
File exists in another pull request
552546f
@avivfaraj
imported radians from math
bc31e3f
@avivfaraj
Updated file according to pre-commit test
974e0a6
@avivfaraj
Updated file
1d4fc81
@avivfaraj
Updated gamma
7bd84b4
@avivfaraj
Deleted duplicate file
2841c11
@avivfaraj
removed pi
cea2deb
@avivfaraj
reversed tests
db7db3b
@avivfaraj
Fixed angle condition
132e495
@avivfaraj
Modified prints to f-string
c0e5071
@avivfaraj
Update horizontal_projectile_motion.py
894fa7f
@avivfaraj
Merge branch 'TheAlgorithms:master' into master
ee49ce7
@avivfaraj
Update horizontal_projectile_motion.py
07646ac
@avivfaraj
Fixes #4710 added exceptions and tests
4e2fcaf
@avivfaraj
Added float tests
dcacc95
@avivfaraj
Fixed type annotations
3f2b238
@avivfaraj
Fixed last annotation
e3678fd
@avivfaraj
Fixed annotations
c37bb95
@avivfaraj
fixed format
5b0249a
@avivfaraj
Add files via upload
06e1eb7
@avivfaraj
Update a1z26.py
77365dc
@avivfaraj
Update enigma_machine2.py
2c9d126
@avivfaraj
Delete horizontal_projectile_motion.py
85b233d
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Sep 14, 2021
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Sep 14, 2021

Closed in favor of #4763

@cclauss cclauss closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avivfaraj @cclauss