horizontal motion code physics#4710
Merged
cclauss merged 30 commits intoTheAlgorithms:masterfrom Apr 4, 2022
avivfaraj:master
Merged
horizontal motion code physics#4710cclauss merged 30 commits intoTheAlgorithms:masterfrom avivfaraj:master
cclauss merged 30 commits intoTheAlgorithms:masterfrom
avivfaraj:master
Conversation
Also printed out results in a math notation
ghost
reviewed
Sep 4, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
removed
the
require type hints
QuantumNovice
suggested changes
Sep 5, 2021
Contributor
QuantumNovice
left a comment
QuantumNovice
left a comment
There was a problem hiding this comment.
Good work.
+10 for really nice comments.
QuantumNovice
approved these changes
Sep 5, 2021
cclauss
requested changes
Sep 6, 2021
ghost
added
awaiting changes
ghost
added
awaiting reviews
cclauss
requested changes
Sep 7, 2021
ghost
added
awaiting reviews
cclauss
reviewed
Sep 14, 2021
Member
ghost
added
tests are failing
Contributor
Author
|
Done revert to previous commit and fixed errors during pre-commit |
cclauss
approved these changes
Apr 4, 2022
poyea
pushed a commit
that referenced
this pull request
May 16, 2022
* Add files via upload * Changed print to f-string Also printed out results in a math notation * Add files via upload * Fixes: #4710 provided return type * File exists in another pull request * imported radians from math * Updated file according to pre-commit test * Updated file * Updated gamma * Deleted duplicate file * removed pi * reversed tests * Fixed angle condition * Modified prints to f-string * Update horizontal_projectile_motion.py * Update horizontal_projectile_motion.py * Fixes #4710 added exceptions and tests * Added float tests * Fixed type annotations * Fixed last annotation * Fixed annotations * fixed format * Revert "fixed format" This reverts commit 5b0249a. Undo changes @wq * Revert "Fixed annotations" This reverts commit c37bb95. * Revert "Fixed last annotation" This reverts commit e3678fd. * Revert "Fixed type annotations" This reverts commit 3f2b238. * Revert to 4e2fcaf * Fixing errors found during pre-commit * Added gauss law * Implemented Lorenz tranformation with four vector * pre-commit fixes * flake8 fixes * More flake8 fixes * Added blank space for flake8 * Added reference * Trailing whitespace fix * Replaced argument u with velocity (descriptive name fix) * Added tests for functions + moved velocity check to beta function * Modified condition to 'not symbolic' in the transform function * trainling whitespace fix * Added type hint for 'smybolic' argument in transform function * Changed reference to avoid pre-commit fails because of spelling issue related to the URL * Added tests for gamma and transformation_matrix functions * Fixed transformation_matrix tests * Fixed tests on beta and gamma functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added code to calculate time, height and distance covered in horizontal projectile motion problem in physics.
Checklist:
Fixes: #{$ISSUE_NO}.