Skip to content

[mypy] Fix type annotations for dynamic programming#4687

Merged
l3str4nge merged 3 commits intoTheAlgorithms:masterfrom
imp2002:fix-mypy-dynamic_programming
Sep 3, 2021
Merged

[mypy] Fix type annotations for dynamic programming#4687
l3str4nge merged 3 commits intoTheAlgorithms:masterfrom
imp2002:fix-mypy-dynamic_programming

Conversation

@imp2002
Copy link
Copy Markdown
Member

@imp2002 imp2002 commented Aug 28, 2021

Related issue #4052

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@imp2002 imp2002 requested a review from Kush1101 as a code owner August 28, 2021 11:28
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Aug 28, 2021
@l3str4nge l3str4nge merged commit c1b15a8 into TheAlgorithms:master Sep 3, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Sep 3, 2021
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@imp2002 @shermanhui
[mypy] Fix type annotations for dynamic programming (TheAlgorithms#4687)
b28fd0c 
* Fix mypy error for knapsack.py

* Fix mypy error for longest_increasing_subsequence

* Fix mypy error for fractional_knapsack_2.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@imp2002 @l3str4nge