Skip to content

mypy --install-types --non-interactive .#4530

Merged
poyea merged 2 commits intomasterfrom
mypy_--install-types_--non-interactive
Sep 22, 2021
Merged

mypy --install-types --non-interactive .#4530
poyea merged 2 commits intomasterfrom
mypy_--install-types_--non-interactive

Conversation

@cclauss
Copy link
Copy Markdown
Member

@cclauss cclauss commented Jul 7, 2021

@dhruvmanila Is this useful/needed given that we do not pin our dependencies?

https://mypy-lang.blogspot.com/2021/06/mypy-0910-released.html

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested a review from dhruvmanila as a code owner July 7, 2021 11:23
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jul 7, 2021
@stale
Copy link
Copy Markdown

stale bot commented Aug 7, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Aug 7, 2021
@cclauss cclauss removed the stale Used to mark an issue or pull request stale. label Aug 7, 2021
@stale
Copy link
Copy Markdown

stale bot commented Sep 6, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Sep 6, 2021
@cclauss cclauss removed the stale Used to mark an issue or pull request stale. label Sep 6, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Sep 22, 2021
@poyea poyea merged commit abc725f into master Sep 22, 2021
@poyea poyea deleted the mypy_--install-types_--non-interactive branch September 22, 2021 17:37
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@cclauss @shermanhui
mypy --install-types --non-interactive . (TheAlgorithms#4530)
2c7373c 
* mypy --install-types --non-interactive .

@dhruvmanila Is this useful/needed given that we do not pin our dependencies?

https://mypy-lang.blogspot.com/2021/06/mypy-0910-released.html

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cclauss @poyea