Skip to content

[mypy] fix hashes folder#4305

Merged
dhruvmanila merged 7 commits intoTheAlgorithms:masterfrom
algobytewise:mypy-fix-hashes-folder
Apr 3, 2021
Merged

[mypy] fix hashes folder#4305
dhruvmanila merged 7 commits intoTheAlgorithms:masterfrom
algobytewise:mypy-fix-hashes-folder

Conversation

@algobytewise
Copy link
Copy Markdown
Contributor

@algobytewise algobytewise commented Apr 2, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Apr 2, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Apr 2, 2021
cclauss
cclauss reviewed Apr 2, 2021
View reviewed changes
hashes/adler32.py Outdated
@@ -15,15 +15,15 @@ def adler32(plain_text: str) -> str:
Itterates and evaluates new value for each character
Copy link
Copy Markdown
Member

@cclauss cclauss Apr 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Itterates and evaluates new value for each character
Iterates and evaluates a new value for each character

cclauss
cclauss reviewed Apr 2, 2021
View reviewed changes
cclauss
cclauss reviewed Apr 2, 2021
View reviewed changes
cclauss
cclauss reviewed Apr 2, 2021
View reviewed changes
cclauss
cclauss reviewed Apr 2, 2021
View reviewed changes
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Apr 2, 2021
dhruvmanila
dhruvmanila requested changes Apr 3, 2021
View reviewed changes
@ghost ghost added the awaiting changes A maintainer has requested changes to this PR label Apr 3, 2021
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Apr 3, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Apr 3, 2021
@dhruvmanila dhruvmanila merged commit a53fcf2 into TheAlgorithms:master Apr 3, 2021
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@algobytewise @cclauss
[mypy] fix hashes folder (TheAlgorithms#4305)
f1f7c65 
* fix hashes-folder

* Update build.yml

* fix doctests

* return-values to int

* Update hashes/adler32.py

* type hints for elements

Co-authored-by: Christian Clauss <cclauss@me.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@algobytewise @cclauss @shermanhui
[mypy] fix hashes folder (TheAlgorithms#4305)
c102027 
* fix hashes-folder

* Update build.yml

* fix doctests

* return-values to int

* Update hashes/adler32.py

* type hints for elements

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@algobytewise @cclauss @dhruvmanila