Skip to content

[mypy] Fix directory arithmetic_analysis#4304

Merged
cclauss merged 4 commits intoTheAlgorithms:masterfrom
algobytewise:fix-directory-arithmetic_analysis
Apr 2, 2021
Merged

[mypy] Fix directory arithmetic_analysis#4304
cclauss merged 4 commits intoTheAlgorithms:masterfrom
algobytewise:fix-directory-arithmetic_analysis

Conversation

@algobytewise
Copy link
Copy Markdown
Contributor

@algobytewise algobytewise commented Apr 2, 2021

Describe your change:

Related Issue: #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Apr 2, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Apr 2, 2021
cclauss
cclauss approved these changes Apr 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Apr 2, 2021
@cclauss cclauss merged commit 5229c74 into TheAlgorithms:master Apr 2, 2021
@cclauss cclauss mentioned this pull request Apr 2, 2021
Closed
14 tasks
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@algobytewise
[mypy] Fix directory arithmetic_analysis (TheAlgorithms#4304)
1ecf1fc 
* fix directory arithmetic_analysis

* Update build.yml

* temporary fix for psf/black bug

see psf/black#2079

* Update in_static_equilibrium.py
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@algobytewise @shermanhui
[mypy] Fix directory arithmetic_analysis (TheAlgorithms#4304)
eb425e7 
* fix directory arithmetic_analysis

* Update build.yml

* temporary fix for psf/black bug

see psf/black#2079

* Update in_static_equilibrium.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@algobytewise @cclauss