Skip to content

.pre-commit-config.yaml: mypy directories that pass#4272

Closed
cclauss wants to merge 16 commits intomasterfrom
mypy-directories-that-pass
Closed

.pre-commit-config.yaml: mypy directories that pass#4272
cclauss wants to merge 16 commits intomasterfrom
mypy-directories-that-pass

Conversation

@cclauss
Copy link
Copy Markdown
Member

@cclauss cclauss commented Mar 19, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested a review from dhruvmanila as a code owner March 19, 2021 07:00
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Mar 19, 2021
@cclauss cclauss mentioned this pull request Mar 19, 2021
Closed
@ghost ghost added the tests are failing Do not merge until tests pass label Mar 19, 2021
@cclauss cclauss requested a review from Kush1101 as a code owner March 19, 2021 07:09
@cclauss cclauss mentioned this pull request Mar 19, 2021
Closed
@cclauss
Copy link
Copy Markdown
Member Author

cclauss commented Mar 19, 2021 •
edited
Loading

Closing in favor of #4273 and #4274 because mypy runs differently in a pre-commit job and a GitHub Action job.

@cclauss cclauss closed this Mar 19, 2021
@cclauss cclauss deleted the mypy-directories-that-pass branch March 19, 2021 10:23
@cclauss cclauss mentioned this pull request Mar 19, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cclauss