Skip to content

Project Euler 206 Solution#3829

Merged
dhruvmanila merged 3 commits intoTheAlgorithms:masterfrom
peteryao7:peteryao7_pe-206
Nov 2, 2020
Merged

Project Euler 206 Solution#3829
dhruvmanila merged 3 commits intoTheAlgorithms:masterfrom
peteryao7:peteryao7_pe-206

Conversation

@peteryao7
Copy link
Copy Markdown
Contributor

@peteryao7 peteryao7 commented Oct 30, 2020 •
edited
Loading

Describe your change:

Adds a solution and explanation for Project Euler 206. Part of issue #2695 and duplicate of #3042.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@peteryao7
Copy link
Copy Markdown
Contributor Author

peteryao7 commented Oct 30, 2020 •
edited
Loading

solution() has no tests because it doesn't make sense for this function to take any input. There's only a certain range of numbers that could possibly be the one, unique answer, which are numbers in [101010103, 138902663] that end in 3 or 7, and I start from the end and count down to the start point. Adding tests would introduce a new layer of logic and complexity not needed to find the answer and I think would make the solution harder to understand.

@peteryao7 peteryao7 mentioned this pull request Oct 30, 2020
Closed
14 tasks
dhruvmanila
dhruvmanila approved these changes Nov 2, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! 🙌
Thank you for your contribution 🥳

@dhruvmanila dhruvmanila merged commit 61cb921 into TheAlgorithms:master Nov 2, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@peteryao7 @stokhos
Project Euler 206 Solution (TheAlgorithms#3829)
9680bdb 
* Readd Project Euler 206 solution for issue TheAlgorithms#2695, dupe of pull request TheAlgorithms#3042

* Add PE 206 to directory

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@peteryao7 @peRFectBeliever
Project Euler 206 Solution (TheAlgorithms#3829)
f595249 
* Readd Project Euler 206 solution for issue TheAlgorithms#2695, dupe of pull request TheAlgorithms#3042

* Add PE 206 to directory

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@peteryao7
Project Euler 206 Solution (TheAlgorithms#3829)
d752893 
* Readd Project Euler 206 solution for issue TheAlgorithms#2695, dupe of pull request TheAlgorithms#3042

* Add PE 206 to directory

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@peteryao7 @shermanhui
Project Euler 206 Solution (TheAlgorithms#3829)
9e06011 
* Readd Project Euler 206 solution for issue TheAlgorithms#2695, dupe of pull request TheAlgorithms#3042

* Add PE 206 to directory

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peteryao7 @dhruvmanila