Skip to content

Added Sleep sort#3731

Closed
Pratham-123 wants to merge 1 commit intoTheAlgorithms:masterfrom
Pratham-123:master
Closed

Added Sleep sort#3731
Pratham-123 wants to merge 1 commit intoTheAlgorithms:masterfrom
Pratham-123:master

Conversation

@Pratham-123
Copy link
Copy Markdown

@Pratham-123 Pratham-123 commented Oct 25, 2020 •
edited
Loading

Describe your change:

Added Sleep Sort

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost
Copy link
Copy Markdown

ghost commented Oct 25, 2020

just type in the following commands:

  • pip install black isort
  • isort sleep_sort.py
  • black sleep_sort.py
    then re upload the modified file, if you encounter any errors, just tell me here.

l3str4nge
l3str4nge requested changes Oct 26, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@l3str4nge l3str4nge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add doctests, typehints and link to wiki or other page with theory

@l3str4nge l3str4nge added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 26, 2020
@stale
Copy link
Copy Markdown

stale bot commented Nov 28, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 28, 2020
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Nov 29, 2020

Closing as a duplicate of #2352

@cclauss cclauss closed this Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l3str4nge l3str4nge l3str4nge requested changes

Assignees

No one assigned

Labels

hacktoberfest-accepted Accepted to be counted towards Hacktoberfest stale Used to mark an issue or pull request stale.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pratham-123 @cclauss @l3str4nge