Skip to content

Hacktoberfest: add project euler for problem 206#3684

Closed
Takosaga wants to merge 5 commits intoTheAlgorithms:masterfrom
Takosaga:add-project-euler-for-problem-206
Closed

Hacktoberfest: add project euler for problem 206#3684
Takosaga wants to merge 5 commits intoTheAlgorithms:masterfrom
Takosaga:add-project-euler-for-problem-206

Conversation

@Takosaga
Copy link
Copy Markdown

@Takosaga Takosaga commented Oct 24, 2020 •
edited
Loading

Describe your change:

Redoing this since still figuring how to pull request
first ever pr hacktoberfest

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

ghost
ghost reviewed Oct 24, 2020
View reviewed changes
@Takosaga
Update project_euler/problem_206/sol1.py
4b42a93 
Co-authored-by: xcodz-dot <71920621+xcodz-dot@users.noreply.github.com>
@Takosaga Takosaga changed the title add project euler for problem 206 Hacktoberfest: add project euler for problem 206 Oct 26, 2020
@dhruvmanila
Copy link
Copy Markdown
Member

dhruvmanila commented Oct 29, 2020

There's already an open PR for Problem 206 #3042.
Closing this PR as we are not accepting multiple solutions to one problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

@Kush1101 Kush1101 Awaiting requested review from Kush1101

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Takosaga @dhruvmanila