Skip to content

Add breadth first search#3632

Closed
Rolv-Apneseth wants to merge 4 commits intoTheAlgorithms:masterfrom
Rolv-Apneseth:add_breadth_first_search
Closed

Add breadth first search#3632
Rolv-Apneseth wants to merge 4 commits intoTheAlgorithms:masterfrom
Rolv-Apneseth:add_breadth_first_search

Conversation

@Rolv-Apneseth
Copy link
Copy Markdown
Contributor

Added a .py file in the searches folder for breadth-first search algorithm with a pathfind visualisation to show the result.

Included doctests and have already run black, mypy and doctests locally.

In relation to #3260

@Rolv-Apneseth
Copy link
Copy Markdown
Contributor Author

Ok I'm sorry I'll leave this here anyway but those first two commits are from a different pull request(#3454). I don't know why the commits from that one are here as well, I made different branches for both. Help would be appreciated. (The failed tests are from those 2 commits, that's a different problem on that other pull request)

@kadhirash
Copy link
Copy Markdown

Hello @Rolv-Apneseth,

I'm thinking they both ended up counting as commits because you pushed commits from (#3454) earlier, regardless of what branch you are on currently. To get rid of the old branch changes, you have to delete them locally and remotely I believe, or stash them in case you would want to come back to it.

Essentially you want to remove your Git changes.

Anyway, after this, the old branch commits wouldn't be part of your commits I'm thinking.

@poyea
Copy link
Copy Markdown
Member

poyea commented Oct 22, 2020

Please run black . and isort for your code. https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md

@poyea
Copy link
Copy Markdown
Member

poyea commented Oct 22, 2020

I think you can enable the github actions in your setting of the fork too.

@poyea
Copy link
Copy Markdown
Member

poyea commented Oct 22, 2020

You may open a new branch for those changes, and file a new PR. When you've done, you can close this PR.

@Rolv-Apneseth
Copy link
Copy Markdown
Contributor Author

@popyea I did open a new branch for these changes just I don't know very well how branches work. I will try to file a new pr. @kadhirash thank you I will try that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants