Made small improvements and shortened prime_check.py#3454
Merged
poyea merged 3 commits intoTheAlgorithms:masterfrom Oct 23, 2020
Rolv-Apneseth:improve-prime_check.py
Merged
Made small improvements and shortened prime_check.py#3454poyea merged 3 commits intoTheAlgorithms:masterfrom Rolv-Apneseth:improve-prime_check.py
poyea merged 3 commits intoTheAlgorithms:masterfrom
Rolv-Apneseth:improve-prime_check.py
Conversation
Contributor
Author
|
Ok Not sure why that check failed, when I run |
Contributor
Author
|
Pre-commit check is not failing on |
Member
|
Please run |
Member
|
I think you can enable the github actions in your setting of the fork too. |
Contributor
Author
|
@popyea of course, thank you for the help! |
poyea
approved these changes
Oct 23, 2020
Member
poyea
left a comment
poyea
left a comment
There was a problem hiding this comment.
Thank you for your pull request!🤩
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Made small improvements and shortened prime_check.py * improved descriptions on tests in prime_check.py * Ran black and isort
peRFectBeliever
pushed a commit
to peRFectBeliever/Python
that referenced
this pull request
Apr 1, 2021
* Made small improvements and shortened prime_check.py * improved descriptions on tests in prime_check.py * Ran black and isort
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
* Made small improvements and shortened prime_check.py * improved descriptions on tests in prime_check.py * Ran black and isort
shermanhui
pushed a commit
to shermanhui/Python
that referenced
this pull request
Oct 22, 2021
* Made small improvements and shortened prime_check.py * improved descriptions on tests in prime_check.py * Ran black and isort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Made small improvements and shortened prime_check.py
Shortened overall code and changed some of the comments/docstrings
For issue #3453