Implement Deutsch-Jozsa Algorithm In Qiskit by abhishek-jaisingh · Pull Request #3447 · TheAlgorithms/Python

abhishek-jaisingh · 2020-10-17T12:38:03Z

Signed-off-by: Abhishek Jaisingh abhi2254015@gmail.com

Describe your change:

Implement Deutsch-Jozsa Algorithm In Qiskit

Add an algorithm?

Checklist:

abhishek-jaisingh · 2020-10-17T13:20:30Z

Implemented the Deutsch-Jozsa Algorithm, one of the first examples of a quantum algorithm that is exponentially faster than any possible deterministic classical algorithm
@cclauss please review

Signed-off-by: Abhishek Jaisingh <abhi2254015@gmail.com>

cclauss · 2020-10-17T13:36:30Z

quantum/deutsch_jozsa.py

+classical algorithm
+
+Premise:
+We are given a hidden Boolean function  f , 


Suggested change

We are given a hidden Boolean function f ,

We are given a hidden Boolean function f,

@cclauss fixed extra whitespace in newly added commit

Signed-off-by: Abhishek Jaisingh <abhi2254015@gmail.com>

dhruvmanila · 2020-10-18T03:38:42Z

@cclauss What's the deal with this GitHub action which applies black to the code? Why doesn't it work on every other PR as well? According to you, it does not work.

Oh, nevermind. I get it why it works on some and not on others. The user has turned on the workflow in their forked copy and this is coming from there.

I propose to remove it and the codespell action as both of them are checked with pre-commit.

cclauss · 2020-10-18T06:03:55Z

The thing that it does do is... If a maintainer (with write privileges to the repo) creates a PR then the Action blackens the entire repo. This ensures that from time to time the entire repo is blackened even if someone lands a PR that is not green.

Go ahead and make the changes that you suggest above.

cclauss · 2020-10-17T13:39:08Z

quantum/deutsch_jozsa.py

+    counts = deutsch_jozsa("constant", 3)
+    print(f"Deutsch Jozsa - Constant Oracle: {counts}")
+
+    counts = deutsch_jozsa("balanced", 3)
+    print(f"Deutsch Jozsa - Balanced Oracle: {counts}")


Suggested change

counts = deutsch_jozsa("constant", 3)

print(f"Deutsch Jozsa - Constant Oracle: {counts}")

counts = deutsch_jozsa("balanced", 3)

print(f"Deutsch Jozsa - Balanced Oracle: {counts}")

print(f"Deutsch Jozsa - Constant Oracle: {deutsch_jozsa("constant", 3)}")

print(f"Deutsch Jozsa - Balanced Oracle: {deutsch_jozsa("balanced", 3)}")

cclauss · 2020-10-18T08:50:17Z

quantum/deutsch_jozsa.py

+        # wrap in X-gates:
+        b = np.random.randint(1, 2 ** n)
+        # Next, format 'b' as a binary string of length 'n', padded with zeros:
+        b_str = format(b, "0" + str(n) + "b")


Please use a f-string.

switched to f-string

cclauss · 2020-10-18T08:51:13Z

quantum/deutsch_jozsa.py

+        # Next, we place the first X-gates. Each digit in our binary string
+        # correspopnds to a qubit, if the digit is 0, we do nothing, if it's 1
+        # we apply an X-gate to that qubit:
+        for qubit in range(len(b_str)):


Please use enumerate() instead of range(len()).

qubit is not a qubit, it is an int. Maybe call it I or index.

using enumerate now, changed var name to index

cclauss · 2020-10-18T08:53:40Z

quantum/deutsch_jozsa.py

+        for qubit in range(n):
+            oracle_qc.cx(qubit, n)
+        # Next, place the final X-gates
+        for qubit in range(len(b_str)):


enumerate()

cclauss · 2020-10-18T08:55:01Z

quantum/deutsch_jozsa.py

+import qiskit as q
+
+
+def dj_oracle(case: str, n: int) -> q.QuantumCircuit:


Perhaps this should be two separate functions.

The variable name n is not self documenting. Can we come up with a more descriptive name.

changed var name from n to num_qubits

However, I feel the function is fine as it is.
I think we shouldn't split the function, as it seems to be more complete in its current form. @cclauss what do you think?

cclauss

RSLGTM

* Implement Deutsch-Jozsa Algorithm In Qiskit Signed-off-by: Abhishek Jaisingh <abhi2254015@gmail.com> * Add Changes Requested In Review Signed-off-by: Abhishek Jaisingh <abhi2254015@gmail.com> * Address Further Review Comments * fixup! Format Python code with psf/black push Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>

abhishek-jaisingh marked this pull request as draft October 17, 2020 12:38

abhishek-jaisingh force-pushed the quantum-deutsch-jozsa branch from 78894a5 to cf60aa6 Compare October 17, 2020 12:45

github-actions bot force-pushed the quantum-deutsch-jozsa branch from 8dd6f21 to a387935 Compare October 17, 2020 12:46

abhishek-jaisingh force-pushed the quantum-deutsch-jozsa branch from a387935 to e9c3d82 Compare October 17, 2020 13:15

github-actions bot force-pushed the quantum-deutsch-jozsa branch from b7ea8ec to ce74e77 Compare October 17, 2020 13:16

abhishek-jaisingh force-pushed the quantum-deutsch-jozsa branch from ce74e77 to d408785 Compare October 17, 2020 13:16

abhishek-jaisingh marked this pull request as ready for review October 17, 2020 13:16

github-actions bot force-pushed the quantum-deutsch-jozsa branch from a766869 to d740492 Compare October 17, 2020 13:17

abhishek-jaisingh force-pushed the quantum-deutsch-jozsa branch from d740492 to 8d9ce52 Compare October 17, 2020 13:22

github-actions bot force-pushed the quantum-deutsch-jozsa branch from 809321b to 7c5da9e Compare October 17, 2020 13:23

Implement Deutsch-Jozsa Algorithm In Qiskit

931a9dd

Signed-off-by: Abhishek Jaisingh <abhi2254015@gmail.com>

abhishek-jaisingh force-pushed the quantum-deutsch-jozsa branch from 7c5da9e to 931a9dd Compare October 17, 2020 13:23

github-actions bot force-pushed the quantum-deutsch-jozsa branch from f17c98a to e4d6caf Compare October 17, 2020 13:24

cclauss reviewed Oct 17, 2020

View reviewed changes

abhishek-jaisingh force-pushed the quantum-deutsch-jozsa branch from e4d6caf to 56bcf6f Compare October 17, 2020 13:41

github-actions bot force-pushed the quantum-deutsch-jozsa branch from 06d8e34 to 07d33ab Compare October 17, 2020 13:42

Add Changes Requested In Review

4e2a95b

Signed-off-by: Abhishek Jaisingh <abhi2254015@gmail.com>

abhishek-jaisingh force-pushed the quantum-deutsch-jozsa branch from 07d33ab to 4e2a95b Compare October 17, 2020 13:43

abhishek-jaisingh requested a review from cclauss October 17, 2020 13:43

github-actions bot force-pushed the quantum-deutsch-jozsa branch from 55faf64 to 517d327 Compare October 17, 2020 13:44

cclauss requested changes Oct 18, 2020

View reviewed changes

Address Further Review Comments

1a33ec4

abhishek-jaisingh force-pushed the quantum-deutsch-jozsa branch from 517d327 to 1a33ec4 Compare October 18, 2020 14:42

fixup! Format Python code with psf/black push

c818db8

github-actions bot force-pushed the quantum-deutsch-jozsa branch from 5745184 to c818db8 Compare October 18, 2020 14:43

abhishek-jaisingh requested a review from cclauss October 18, 2020 14:50

cclauss approved these changes Oct 18, 2020

View reviewed changes

cclauss merged commit beb2c35 into TheAlgorithms:master Oct 18, 2020

dhruvmanila mentioned this pull request Oct 24, 2020

Move validate_solutions and add durations flag to pytest.ini #3704

Merged

4 tasks

	We are given a hidden Boolean function f ,
	We are given a hidden Boolean function f,

		import qiskit as q


		def dj_oracle(case: str, n: int) -> q.QuantumCircuit:

Uh oh!

Conversation

abhishek-jaisingh commented Oct 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

abhishek-jaisingh commented Oct 17, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abhishek-jaisingh Oct 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dhruvmanila commented Oct 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cclauss commented Oct 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abhishek-jaisingh Oct 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abhishek-jaisingh commented Oct 17, 2020 •

edited

Loading

abhishek-jaisingh Oct 17, 2020 •

edited

Loading

dhruvmanila commented Oct 18, 2020 •

edited

Loading

cclauss commented Oct 18, 2020 •

edited

Loading

abhishek-jaisingh Oct 18, 2020 •

edited

Loading