Skip to content

.pre-commit-config.yaml: Disable trailing-whitespace fixer#3306

Merged
cclauss merged 2 commits intomasterfrom
Disable-trailing-whitespace-fixer
Oct 15, 2020
Merged

.pre-commit-config.yaml: Disable trailing-whitespace fixer#3306
cclauss merged 2 commits intomasterfrom
Disable-trailing-whitespace-fixer

Conversation

@cclauss
Copy link
Copy Markdown
Member

@cclauss cclauss commented Oct 15, 2020

Describe your change:

Some doctests use print(x, sep=" ") and black will not fix inside triple quotes.
It is too confusing for new contributors to understand this and how to fix.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss cclauss requested a review from dhruvmanila October 15, 2020 08:43
@cclauss cclauss mentioned this pull request Oct 15, 2020
Merged
14 tasks
@cclauss cclauss merged commit aeb6edc into master Oct 15, 2020
@cclauss cclauss deleted the Disable-trailing-whitespace-fixer branch October 15, 2020 09:11
@dhruvmanila
Copy link
Copy Markdown
Member

dhruvmanila commented Oct 15, 2020

I think this will create large amounts of files with unnecessary whitespaces everywhere. I think it's just one file which needed whitespace in its doctest which we ignored.

@cclauss
Copy link
Copy Markdown
Member Author

cclauss commented Oct 15, 2020

Please revert.

@dhruvmanila
Copy link
Copy Markdown
Member

dhruvmanila commented Oct 15, 2020

I will create a new PR as this changed a lot of other things as well.

@cclauss
Copy link
Copy Markdown
Member Author

cclauss commented Oct 15, 2020 •
edited
Loading

Already done in #3318

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@cclauss @stokhos
.pre-commit-config.yaml: Disable trailing-whitespace fixer (TheAlgori…
ef92379 
…thms#3306)

* .pre-commit-config.yaml: Disable trailing-whitespace fixer

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@cclauss
.pre-commit-config.yaml: Disable trailing-whitespace fixer (TheAlgori…
92dc213 
…thms#3306)

* .pre-commit-config.yaml: Disable trailing-whitespace fixer

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l3str4nge l3str4nge l3str4nge approved these changes

@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cclauss @dhruvmanila @l3str4nge