Update README.md for Project Euler#3256
Merged
dhruvmanila merged 6 commits intoTheAlgorithms:masterfrom Oct 15, 2020
Merged
Conversation
Travis tests have failedHey @dhruvmanila, TravisBuddy Request Identifier: caff6b60-0dc4-11eb-9111-f326d0cb7f09 |
Travis tests have failedHey @dhruvmanila, TravisBuddy Request Identifier: 6be7cdb0-0dd9-11eb-964d-5d54b4986782 |
Member
Author
|
Hey, @cclauss Can you take a look at this? Thanks if you do. |
poyea
approved these changes
Oct 15, 2020
Member
poyea
left a comment
poyea
left a comment
There was a problem hiding this comment.
That's cool. I just add a few suggestions on wording, etc. Thank you for your pull request!🤩
Co-authored-by: John Law <johnlaw.po@gmail.com>
dhruvmanila
pushed a commit
that referenced
this pull request
Oct 15, 2020
dhruvmanila
pushed a commit
that referenced
this pull request
Oct 15, 2020
dhruvmanila
pushed a commit
that referenced
this pull request
Oct 15, 2020
dhruvmanila
pushed a commit
that referenced
this pull request
Oct 16, 2020
* Added solution for Project Euler problem 72. * Update type annotations and 0-padding of the directory name. Reference: #3256 * Rename sol1.py to sol2.py * Added newline at the end of sol2.py * Revert sol1.py
dhruvmanila
added a commit
that referenced
this pull request
Oct 16, 2020
* Added solution for Project Euler problem 174. * Fixed import order and removed executable permission from sol1.py * Update docstrings, doctests, and annotations. Reference: #3256 * Update docstring * Update sol1.py Co-authored-by: Dhruv <dhruvmanila@gmail.com>
dhruvmanila
pushed a commit
that referenced
this pull request
Oct 16, 2020
* Added solution for Project Euler problem 75. * Added doctest for solution() in project_euler/problem_75/sol1.py * Update docstring and 0-padding of directory name. Reference: #3256 * More descriptive variable names * Moved solution explanation to module-level docstring
dhruvmanila
pushed a commit
that referenced
this pull request
Oct 24, 2020
* Added solution for Project Euler problem 38. Fixes: #2695 * Update docstring and 0-padding in directory name. Reference: #3256 * Renamed is_9_palindromic to is_9_pandigital. * Changed just-in-case return value for solution() to None. * Moved exmplanation to module-level docstring and deleted unnecessary import
dhruvmanila
pushed a commit
that referenced
this pull request
Oct 29, 2020
dhruvmanila
pushed a commit
that referenced
this pull request
Nov 21, 2020
* Added solution for Project Euler problem 129. * Added doctest for solution() in project_euler/problem_129/sol1.py * Update formatting. Reference: #3256 * More descriptive function and variable names, more doctests.
dhruvmanila
pushed a commit
that referenced
this pull request
Nov 27, 2020
* Added solution for Project Euler problem 77. * Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: #3256 * Implemented lru_cache, better type hints, more doctests for problem 77 * updating DIRECTORY.md * updating DIRECTORY.md * Added solution for Project Euler problem 77. Fixes: 2695 * Update docstrings, doctest, type annotations and 0-padding in directory name. Reference: #3256 * Implemented lru_cache, better type hints, more doctests for problem 77 * better variable names Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Update README.md for Project Euler * Add link to solution template * Add newlines for better separation * Add __name__ == __main__ block in template * Apply suggestions from code review Co-authored-by: John Law <johnlaw.po@gmail.com> * Improve introduction part Co-authored-by: John Law <johnlaw.po@gmail.com>
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added solution for Project Euler problem 113. TheAlgorithms#2695 * Updated formatting and doctests. Reference: TheAlgorithms#3256
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added solution for Project Euler problemm problem 173. TheAlgorithms#2695 * Added docstring * Update formatting, doctest and annotations. Reference: TheAlgorithms#3256
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added solution for Project Euler problem 74. Fixes: TheAlgorithms#2695 * Added doctest for solution() in project_euler/problem_74/sol1.py * Update docstrings and 0-padding of directory name. Reference: TheAlgorithms#3256
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added solution for Project Euler problem 72. * Update type annotations and 0-padding of the directory name. Reference: TheAlgorithms#3256 * Rename sol1.py to sol2.py * Added newline at the end of sol2.py * Revert sol1.py
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added solution for Project Euler problem 174. * Fixed import order and removed executable permission from sol1.py * Update docstrings, doctests, and annotations. Reference: TheAlgorithms#3256 * Update docstring * Update sol1.py Co-authored-by: Dhruv <dhruvmanila@gmail.com>
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added solution for Project Euler problem 91. Reference: TheAlgorithms#2695 * Added doctest for solution() in project_euler/problem_91/sol1.py * Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256 * Update sol1.py Co-authored-by: Dhruv <dhruvmanila@gmail.com>
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added solution for Project Euler problem 75. * Added doctest for solution() in project_euler/problem_75/sol1.py * Update docstring and 0-padding of directory name. Reference: TheAlgorithms#3256 * More descriptive variable names * Moved solution explanation to module-level docstring
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added solution for Project Euler problem 38. Fixes: TheAlgorithms#2695 * Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256 * Renamed is_9_palindromic to is_9_pandigital. * Changed just-in-case return value for solution() to None. * Moved exmplanation to module-level docstring and deleted unnecessary import
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added solution for Project Euler problem 87. Fixes: TheAlgorithms#2695 * Update docstring and 0-padding in directory name. Reference: TheAlgorithms#3256
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added solution for Project Euler problem 129. * Added doctest for solution() in project_euler/problem_129/sol1.py * Update formatting. Reference: TheAlgorithms#3256 * More descriptive function and variable names, more doctests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To see what it looks like: https://github.com/dhruvmanila/Python/blob/readme-pe/project_euler/README.md
In line with the following comments:
Describe your change:
Checklist: