Skip to content

Added binary tree mirror algorithm#3159

Merged
cclauss merged 7 commits intoTheAlgorithms:masterfrom
susmith98:mirror
Oct 14, 2020
Merged

Added binary tree mirror algorithm#3159
cclauss merged 7 commits intoTheAlgorithms:masterfrom
susmith98:mirror

Conversation

@susmith98
Copy link
Copy Markdown
Contributor

@susmith98 susmith98 commented Oct 10, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@susmith98 susmith98 requested a review from cclauss as a code owner October 10, 2020 16:28
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Oct 10, 2020

Travis tests have failed

Hey @susmith98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 631e7aa0-0b16-11eb-9624-fb6a3f266bd5

@susmith98
Copy link
Copy Markdown
Contributor Author

susmith98 commented Oct 10, 2020

Hey @poyea :), can you please review this.

@susmith98
Copy link
Copy Markdown
Contributor Author

susmith98 commented Oct 13, 2020

Hey @poyea , can please add hactoberfest label for this if eligible?

cclauss
cclauss requested changes Oct 13, 2020
View reviewed changes
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Oct 13, 2020

Travis tests have failed

Hey @susmith98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 5a7a6e60-0d2b-11eb-9111-f326d0cb7f09

cclauss
cclauss requested changes Oct 13, 2020
View reviewed changes
@susmith98
Copy link
Copy Markdown
Contributor Author

susmith98 commented Oct 13, 2020 •
edited by cclauss
Loading

Thank you so much @cclauss for patiently pointing out the improvements in this PR 👍 . I am new to Python and these suggestions really helped me to know some small yet important concepts and coding practices.

I updated the PR. Please let me know if anything has to be changed in it.

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Oct 13, 2020

Travis tests have failed

Hey @susmith98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d6db7fc0-0d31-11eb-9111-f326d0cb7f09

@susmith98 susmith98 requested a review from cclauss October 13, 2020 09:03
@susmith98
Copy link
Copy Markdown
Contributor Author

susmith98 commented Oct 14, 2020

Can you please merge this?

cclauss
cclauss approved these changes Oct 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@cclauss cclauss merged commit dc06958 into TheAlgorithms:master Oct 14, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@susmith98 @stokhos
Added binary tree mirror algorithm (TheAlgorithms#3159)
07530aa 
* Added binary tree mirror algorithm

* Minor changes

* Resolved comments

* Minor Changes

* resolved comments and updated doctests

* updated doctests

* updating DIRECTORY.md

Co-authored-by: svedire <VedireSusmith_Reddy@intuit.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@susmith98
Added binary tree mirror algorithm (TheAlgorithms#3159)
599b257 
* Added binary tree mirror algorithm

* Minor changes

* Resolved comments

* Minor Changes

* resolved comments and updated doctests

* updated doctests

* updating DIRECTORY.md

Co-authored-by: svedire <VedireSusmith_Reddy@intuit.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@susmith98 @TravisBuddy @cclauss