Skip to content

Created max_sum_sliding_window in Python/other#3065

Merged
dhruvmanila merged 7 commits intoTheAlgorithms:masterfrom
Kush1101:master
Oct 9, 2020
Merged

Created max_sum_sliding_window in Python/other#3065
dhruvmanila merged 7 commits intoTheAlgorithms:masterfrom
Kush1101:master

Conversation

@Kush1101
Copy link
Copy Markdown
Member

@Kush1101 Kush1101 commented Oct 8, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Kush1101 Kush1101 added the awaiting reviews This PR is ready to be reviewed label Oct 8, 2020
@Kush1101
Copy link
Copy Markdown
Member Author

Kush1101 commented Oct 8, 2020

@dhruvmanila @shellhub, Please review it.

dhruvmanila
dhruvmanila reviewed Oct 9, 2020
View reviewed changes
@dhruvmanila
Copy link
Copy Markdown
Member

dhruvmanila commented Oct 9, 2020 •
edited
Loading

I might be wrong but it seems that this is an incorrect algorithm.

As far as I understand you are finding the maximum value from the sum of k consecutive integers in a list of integers which means:

>>> arr = [1, 4, 2, 10, 2, 13, 1, 0, 2]
>>> k = 4
>>> max_sum(arr, k)  # This should give me 27
16

Your algorithm provides 16 as the answer but the answer clearly is 27. Your algorithm is just giving the sum of the last k integers. If so, please test your algorithm thoroughly before submitting. Use black box and white box testing, random tests and especially test the edge cases.

@Kush1101
Copy link
Copy Markdown
Member Author

Kush1101 commented Oct 9, 2020

There was a bug in the program. I corrected it and added more tests. Now the algorithm works just the way it should.

dhruvmanila
dhruvmanila requested changes Oct 9, 2020
View reviewed changes
@dhruvmanila
Copy link
Copy Markdown
Member

dhruvmanila commented Oct 9, 2020

Also, can you take a look at #3094 ?
Thanks.

@dhruvmanila dhruvmanila merged commit ec9f6b6 into TheAlgorithms:master Oct 9, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Kush1101 @stokhos
Created max_sum_sliding_window in Python/other (TheAlgorithms#3065)
f4ad6d3 
* Add files via upload

* Update max_sum_sliding_window.py

* Update max_sum_sliding_window.py

* Update max_sum_sliding_window.py

* Added more tests

* Update max_sum_sliding_window.py

* Update max_sum_sliding_window.py
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@Kush1101
Created max_sum_sliding_window in Python/other (TheAlgorithms#3065)
5a083d4 
* Add files via upload

* Update max_sum_sliding_window.py

* Update max_sum_sliding_window.py

* Update max_sum_sliding_window.py

* Added more tests

* Update max_sum_sliding_window.py

* Update max_sum_sliding_window.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Kush1101 @dhruvmanila