Hacktoberfest 2020 - Style Improvements for project_euler/problem_26#2958
Merged
dhruvmanila merged 12 commits intoTheAlgorithms:masterfrom Oct 8, 2020
nstoik:master
Merged
Hacktoberfest 2020 - Style Improvements for project_euler/problem_26#2958dhruvmanila merged 12 commits intoTheAlgorithms:masterfrom nstoik:master
dhruvmanila merged 12 commits intoTheAlgorithms:masterfrom
nstoik:master
Conversation
dhruvmanila
requested changes
Oct 7, 2020
dhruvmanila
reviewed
Oct 8, 2020
dhruvmanila
approved these changes
Oct 8, 2020
Member
dhruvmanila
left a comment
dhruvmanila
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
dhruvmanila
added
the
hacktoberfest-accepted
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* add typehints and docstrings * add typehint and default value * add typehint and default value. Removed unused variable. * do not modifiy the given solution * add doctests * update sol1 after running black * add typehint, docstring, and doctest * update sol2 after running black * add full problem statement and solution function with typehint and doctest * renamed original function instead of adding new one * don't alter original solution
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
* add typehints and docstrings * add typehint and default value * add typehint and default value. Removed unused variable. * do not modifiy the given solution * add doctests * update sol1 after running black * add typehint, docstring, and doctest * update sol2 after running black * add full problem statement and solution function with typehint and doctest * renamed original function instead of adding new one * don't alter original solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Style and testing improvements for Project Euler problem 26
Related to: #2786
Checklist:
Fixes: #{$ISSUE_NO}.