Skip to content

Hacktoberfest: Add solution for Project Euler: Problem 89#2948

Merged
dhruvmanila merged 4 commits intoTheAlgorithms:masterfrom
coryallegory:euler89
Nov 21, 2020
Merged

Hacktoberfest: Add solution for Project Euler: Problem 89#2948
dhruvmanila merged 4 commits intoTheAlgorithms:masterfrom
coryallegory:euler89

Conversation

@coryallegory
Copy link
Copy Markdown
Contributor

@coryallegory coryallegory commented Oct 6, 2020 •
edited
Loading

Describe your change:

Adding a Python implementation for Project Euler problem 89
https://projecteuler.net/problem=89

Contributes to Issue #2695

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@coryallegory coryallegory force-pushed the euler89 branch 2 times, most recently from 5a9c5b2 to e737971 Compare October 6, 2020 20:49
@coryallegory coryallegory changed the title add solution for euler problem 89 Add solution for Project Euler: Problem 89 Oct 6, 2020
dhruvmanila
dhruvmanila reviewed Oct 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Announcement:

@coryallegory

This message is sent to all pull requests which are OPEN, NOT MERGED, not containing 'wontfix' label and contains 'Project Euler' or 'Project' or 'Euler' (case doesn't matter) in their title. If this message doesn't apply to your pull request, please ignore this.

Message:

This is to notify all the users submitting a pull request for the Project Euler solution that the README.md file has been updated with all the style requirements necessary for the directory and solution files. Please read through it and make all the necessary changes required to your submission.

@dhruvmanila dhruvmanila added awaiting changes A maintainer has requested changes to this PR Do not meet Solution Guidelines merge conflicts Open a new PR or rebase on the latest commit labels Oct 24, 2020
@coryallegory coryallegory force-pushed the euler89 branch 2 times, most recently from 1c9b0af to eadd777 Compare October 26, 2020 20:46
@coryallegory coryallegory changed the title Add solution for Project Euler: Problem 89 Hacktoberfest: Add solution for Project Euler: Problem 89 Oct 26, 2020
dhruvmanila
dhruvmanila requested changes Nov 4, 2020
View reviewed changes
@dhruvmanila
Copy link
Copy Markdown
Member

dhruvmanila commented Nov 4, 2020

Awesome work on making another file for testing! 🎉

There's still the merge conflict. You need to rebase on the latest commit from master.

@coryallegory coryallegory force-pushed the euler89 branch 2 times, most recently from cc2f75e to b5be6d3 Compare November 21, 2020 04:28
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 21, 2020
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 21, 2020
dhruvmanila
dhruvmanila approved these changes Nov 21, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Thanks for doing this :)

@ghost ghost removed the awaiting changes A maintainer has requested changes to this PR label Nov 21, 2020
@dhruvmanila dhruvmanila removed the merge conflicts Open a new PR or rebase on the latest commit label Nov 21, 2020
@dhruvmanila dhruvmanila merged commit b55e132 into TheAlgorithms:master Nov 21, 2020
@coryallegory coryallegory deleted the euler89 branch November 21, 2020 06:16
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@coryallegory @stokhos
Add solution for Project Euler: Problem 89 (TheAlgorithms#2948)
a230f1b 
* add solution for euler problem 89

* updates to accommodate euler solution guideline updates

* use more descriptive vars

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@coryallegory @peRFectBeliever
Add solution for Project Euler: Problem 89 (TheAlgorithms#2948)
a872c1a 
* add solution for euler problem 89

* updates to accommodate euler solution guideline updates

* use more descriptive vars

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@coryallegory
Add solution for Project Euler: Problem 89 (TheAlgorithms#2948)
9c7970b 
* add solution for euler problem 89

* updates to accommodate euler solution guideline updates

* use more descriptive vars

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@coryallegory @shermanhui
Add solution for Project Euler: Problem 89 (TheAlgorithms#2948)
4779c86 
* add solution for euler problem 89

* updates to accommodate euler solution guideline updates

* use more descriptive vars

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

+1 more reviewer

@kbakdev kbakdev kbakdev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coryallegory @dhruvmanila @kbakdev