Skip to content

Added static typing to backtracking algorithms#2684

Merged
poyea merged 6 commits intoTheAlgorithms:masterfrom
jenia90:jenia90/add_static_typing_backtracking
Nov 29, 2020
Merged

Added static typing to backtracking algorithms#2684
poyea merged 6 commits intoTheAlgorithms:masterfrom
jenia90:jenia90/add_static_typing_backtracking

Conversation

@jenia90
Copy link
Copy Markdown
Contributor

@jenia90 jenia90 commented Oct 3, 2020 •
edited
Loading

For issue #2128: I've added static typing to every function that was missing it in the backtracking algorithms folder.

@spamegg1
Copy link
Copy Markdown
Contributor

spamegg1 commented Oct 3, 2020

Looks good!

@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 5, 2020
@stale
Copy link
Copy Markdown

stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
@stale stale bot removed the stale Used to mark an issue or pull request stale. label Nov 29, 2020
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Nov 29, 2020
@ghost ghost added require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required and removed awaiting reviews This PR is ready to be reviewed labels Nov 29, 2020
@poyea poyea merged commit e077662 into TheAlgorithms:master Nov 29, 2020
@dhruvmanila
Copy link
Copy Markdown
Member

dhruvmanila commented Nov 29, 2020

Um, this pull request contains invalid type hints, I don't understand why you merged it? @poyea
This is only increasing the mypy errors in this repository 😞

@poyea
Copy link
Copy Markdown
Member

poyea commented Nov 29, 2020

Um, this pull request contains invalid type hints, I don't understand why you merged it? @poyea
This is only increasing the mypy errors in this repository 😞

Where's it? The code passes the check, but we can fix it in a new one quickly.

@jenia90 jenia90 deleted the jenia90/add_static_typing_backtracking branch November 29, 2020 16:43
@dhruvmanila
Copy link
Copy Markdown
Member

dhruvmanila commented Nov 29, 2020

Currently, we are not running mypy in our CI as there are more than 700 errors in the entire repository.
https://github.com/TheAlgorithms/Python/blob/master/.pre-commit-config.yaml#L33

Any PR which provides type hints should be checked by the maintainer by running mypy locally until we start running it in our CI.

@poyea
Copy link
Copy Markdown
Member

poyea commented Nov 29, 2020

@jenia90 would you be able to fix this - probably due to [int]? Otherwise I can fix this.

@dhruvmanila
Copy link
Copy Markdown
Member

dhruvmanila commented Nov 29, 2020

Please run mypy to whichever files is being fixed.

@poyea poyea mentioned this pull request Nov 29, 2020
Merged
14 tasks
dhruvmanila pushed a commit that referenced this pull request Nov 29, 2020
@poyea
Fix mypy in #2684 (#3987)
25164bb 
* Fix mypy in #2684

* fix pre-commit
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@jenia90 @poyea @stokhos
Add static typing to backtracking algorithms (TheAlgorithms#2684)
3b0e992 
* Added static typing to backtracking algorithms

* Ran psf/black to fix some minor issues.

* updating DIRECTORY.md

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <johnlaw.po@gmail.com>
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@poyea @stokhos
Fix mypy in TheAlgorithms#2684 (TheAlgorithms#3987)
5b9f710 
* Fix mypy in TheAlgorithms#2684

* fix pre-commit
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@jenia90 @poyea @peRFectBeliever
Add static typing to backtracking algorithms (TheAlgorithms#2684)
3fa9e19 
* Added static typing to backtracking algorithms

* Ran psf/black to fix some minor issues.

* updating DIRECTORY.md

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <johnlaw.po@gmail.com>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@poyea @peRFectBeliever
Fix mypy in TheAlgorithms#2684 (TheAlgorithms#3987)
6afee53 
* Fix mypy in TheAlgorithms#2684

* fix pre-commit
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@jenia90 @poyea
Add static typing to backtracking algorithms (TheAlgorithms#2684)
953c74c 
* Added static typing to backtracking algorithms

* Ran psf/black to fix some minor issues.

* updating DIRECTORY.md

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <johnlaw.po@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@poyea
Fix mypy in TheAlgorithms#2684 (TheAlgorithms#3987)
a834991 
* Fix mypy in TheAlgorithms#2684

* fix pre-commit
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@jenia90 @poyea @shermanhui
Add static typing to backtracking algorithms (TheAlgorithms#2684)
d30db78 
* Added static typing to backtracking algorithms

* Ran psf/black to fix some minor issues.

* updating DIRECTORY.md

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: John Law <johnlaw.po@gmail.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@poyea @shermanhui
Fix mypy in TheAlgorithms#2684 (TheAlgorithms#3987)
8f9b7e8 
* Fix mypy in TheAlgorithms#2684

* fix pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea approved these changes

Assignees

No one assigned

Labels

hacktoberfest-accepted Accepted to be counted towards Hacktoberfest require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jenia90 @spamegg1 @dhruvmanila @poyea