Fix: Multiple errors in fibonacci search.#2659
Merged
dhruvmanila merged 13 commits intoTheAlgorithms:masterfrom Oct 8, 2020
Merged
Fix: Multiple errors in fibonacci search.#2659dhruvmanila merged 13 commits intoTheAlgorithms:masterfrom
dhruvmanila merged 13 commits intoTheAlgorithms:masterfrom
Conversation
- Test lists were not ordered, this is required for Fibonacci search - Place documentation of function inside function - Create multiple different tests including, float, char and negatives - Add type hints in line with TheAlgorithms#2128
dhruvmanila
requested changes
Oct 3, 2020
dhruvmanila
added
the
awaiting changes
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
NumberPiOso
commented
Oct 4, 2020
Contributor
Author
|
I think we are done here. Are not we? |
dhruvmanila
requested changes
Oct 6, 2020
Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Travis tests have failedHey @NumberPiOso, TravisBuddy Request Identifier: 10db2900-08a0-11eb-9b15-83942378e0dd |
dhruvmanila
reviewed
Oct 8, 2020
dhruvmanila
approved these changes
Oct 8, 2020
Member
dhruvmanila
left a comment
dhruvmanila
left a comment
There was a problem hiding this comment.
Looks good now! Thank you for your contribution!
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Fix: Multiple errors in fibonacci search. - Test lists were not ordered, this is required for Fibonacci search - Place documentation of function inside function - Create multiple different tests including, float, char and negatives - Add type hints in line with TheAlgorithms#2128 * Fix: sort of modules and delete typehint. * Apply suggestions from code review Co-authored-by: Dhruv <dhruvmanila@gmail.com> * Correct invocation of lru_cache. * Add check for input in fibonacci and doctest. * Correct typehints to comply to numpy style. * Correct ValueError to TypeError. Co-authored-by: Dhruv <dhruvmanila@gmail.com> * Correct doctest for TypeError. * Rename single letter names as mentioned in CONTRIBUTING.md. * Fix: Bug in big lists. * Remove print(.) in doctests. * Refactor iterator to while loop. * Update searches/fibonacci_search.py Co-authored-by: Dhruv <dhruvmanila@gmail.com>
Panquesito7
pushed a commit
to Panquesito7/Python
that referenced
this pull request
May 13, 2021
* Fix: Multiple errors in fibonacci search. - Test lists were not ordered, this is required for Fibonacci search - Place documentation of function inside function - Create multiple different tests including, float, char and negatives - Add type hints in line with TheAlgorithms#2128 * Fix: sort of modules and delete typehint. * Apply suggestions from code review Co-authored-by: Dhruv <dhruvmanila@gmail.com> * Correct invocation of lru_cache. * Add check for input in fibonacci and doctest. * Correct typehints to comply to numpy style. * Correct ValueError to TypeError. Co-authored-by: Dhruv <dhruvmanila@gmail.com> * Correct doctest for TypeError. * Rename single letter names as mentioned in CONTRIBUTING.md. * Fix: Bug in big lists. * Remove print(.) in doctests. * Refactor iterator to while loop. * Update searches/fibonacci_search.py Co-authored-by: Dhruv <dhruvmanila@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.