Perfect square using binary search#2351
Merged
cclauss merged 3 commits intoTheAlgorithms:masterfrom Aug 25, 2020
ihebu:perfect-square-binary-search
Merged
Perfect square using binary search#2351cclauss merged 3 commits intoTheAlgorithms:masterfrom ihebu:perfect-square-binary-search
cclauss merged 3 commits intoTheAlgorithms:masterfrom
ihebu:perfect-square-binary-search
Conversation
rtvk007
approved these changes
Aug 25, 2020
cclauss
reviewed
Aug 25, 2020
| >>> perfect_square_binary_search(0) | ||
| True | ||
| >>> perfect_square_binary_search(10) | ||
| False |
Member
There was a problem hiding this comment.
tests for -1, 1.1, "a", None, []?
Contributor
Author
There was a problem hiding this comment.
should I first add input validation inside the function, or should I just include those tests ?
Member
There was a problem hiding this comment.
Write the tests first and see how your function deals with unexpected input. The trick is to not write validation code if you don't have to. If your function is already going to raise an IndexError, TypeError, ValueError, etc. then you have no work to do. Just look for cases where your code would silently fail or would deliver nonsense results.
Contributor
Author
There was a problem hiding this comment.
Got it.Thank you so much !
Things should be good now.
swapnanildutta
approved these changes
Aug 25, 2020
cclauss
approved these changes
Aug 25, 2020
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Add perfect_square_binary_search * Update tests * Add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.