Insertion sort : type hint, docstring#2327
Merged
cclauss merged 6 commits intoTheAlgorithms:masterfrom Aug 23, 2020
Merged
Conversation
Bennyhwanggggg
suggested changes
Aug 22, 2020
Comment on lines
+4
to
+8
| This algorithm sorts a collection by comparing adjacent elements. | ||
| When it finds that order is not respected, it moves the element compared | ||
| backward until order is right. | ||
| It then goes back directly to element initial position resuming forward comparison. | ||
|
|
There was a problem hiding this comment.
should be "it moves the element by comparing backward until the order is right and insert it there. It then goes back to the element's initial position and resumes forward comparison."
Otherwise, the English sounds weird here.
cclauss
approved these changes
Aug 23, 2020
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* insertion sort : docstring, type hinting * Update insertion_sort.py Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Insertion sort : module docstring + type hint.
Checklist:
Fixes: #{$ISSUE_NO}.