Skip to content

Add surface area class#2183

Merged
cclauss merged 10 commits intoTheAlgorithms:masterfrom
lance-pyles:add-surface-area-class
Jul 6, 2020
Merged

Add surface area class#2183
cclauss merged 10 commits intoTheAlgorithms:masterfrom
lance-pyles:add-surface-area-class

Conversation

@lance-pyles
Copy link
Copy Markdown
Contributor

@lance-pyles lance-pyles commented Jul 6, 2020 •
edited by cclauss
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jul 6, 2020

Hey @lance-pyles,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d85cd410-bfcb-11ea-8212-0f9c14daf924

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Jul 6, 2020

Add an extra carrage return before each function on lines 9 and 20.

./maths/surface_area.py:9:1: E302 expected 2 blank lines, found 1
./maths/surface_area.py:20:1: E302 expected 2 blank lines, found 1

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Jul 6, 2020

Should these functions be added to area.py?

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jul 6, 2020

Hey @lance-pyles,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e95e7a80-bfcf-11ea-8212-0f9c14daf924

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jul 6, 2020

Hey @lance-pyles,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 96ffa2e0-bfd0-11ea-8212-0f9c14daf924

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jul 6, 2020

Hey @lance-pyles,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 2fe6daf0-bfd1-11ea-8212-0f9c14daf924

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jul 6, 2020

Hey @lance-pyles,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 7091b9d0-bfd1-11ea-8212-0f9c14daf924

cclauss
cclauss approved these changes Jul 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice submission! Thanks for doing this.

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jul 6, 2020

Travis tests have failed

Hey @lance-pyles,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 849e4bc0-bfd4-11ea-8212-0f9c14daf924

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jul 6, 2020

Travis tests have failed

Hey @lance-pyles,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: c86df4d0-bfd5-11ea-8212-0f9c14daf924

@cclauss cclauss merged commit 48df91d into TheAlgorithms:master Jul 6, 2020
@lance-pyles
Copy link
Copy Markdown
Contributor Author

lance-pyles commented Jul 7, 2020

Thanks for including my change. I've been learning Python and this is my first pull request for it.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@lance-pyles @stokhos
Add surface area class (TheAlgorithms#2183)
a366d34 
* add surface area class

* add new line to end of file

* move surface area class into area class

* add missing import

* added pi import

* fix typo

* added blank line

* fixed more import issues

* comment fix

* comment fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lance-pyles @TravisBuddy @cclauss