Skip to content

Add url and typing hint for BFS#2156

Merged
cclauss merged 13 commits intoTheAlgorithms:masterfrom
asukaminato0721:master
Jun 25, 2020
Merged

Add url and typing hint for BFS#2156
cclauss merged 13 commits intoTheAlgorithms:masterfrom
asukaminato0721:master

Conversation

@asukaminato0721
Copy link
Copy Markdown

@asukaminato0721 asukaminato0721 commented Jun 25, 2020

Describe your change:

Add typing for bfs and make the code more brief.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 25, 2020

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 199a2480-b6f0-11ea-bb0d-6965ce86ea0c

cclauss
cclauss reviewed Jun 25, 2020
View reviewed changes
cclauss
cclauss reviewed Jun 25, 2020
View reviewed changes
@cclauss
rename the function
2cac294 
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss reviewed Jun 25, 2020
View reviewed changes
@cclauss
Update graphs/bfs.py
76e680f 
Co-authored-by: Christian Clauss <cclauss@me.com>
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 25, 2020

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a5cfeeb0-b6f2-11ea-bb0d-6965ce86ea0c

asukaminato0721
asukaminato0721 commented Jun 25, 2020
View reviewed changes
Copy link
Copy Markdown
Author

@asukaminato0721 asukaminato0721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix several hidden troubles.

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 25, 2020

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f9755aa0-b6f2-11ea-bb0d-6965ce86ea0c

asukaminato0721
asukaminato0721 commented Jun 25, 2020
View reviewed changes
Copy link
Copy Markdown
Author

@asukaminato0721 asukaminato0721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the type of return value of bfs.

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 25, 2020

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 760f6510-b6f3-11ea-bb0d-6965ce86ea0c

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Jun 25, 2020 •
edited
Loading

You will need to change all instances of bfs() to breadth_first_search().

change the function name.
ff831b1 
change all instances of bfs() to breadth_first_search().
asukaminato0721
asukaminato0721 commented Jun 25, 2020
View reviewed changes
Copy link
Copy Markdown
Author

@asukaminato0721 asukaminato0721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change all instances of bfs() to breadth_first_search().

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 25, 2020

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 76d334d0-b6f4-11ea-bb0d-6965ce86ea0c

asukaminato0721
asukaminato0721 commented Jun 25, 2020
View reviewed changes
Copy link
Copy Markdown
Author

@asukaminato0721 asukaminato0721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the function name in annotate.

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 25, 2020

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: eb9c0e90-b6f4-11ea-bb0d-6965ce86ea0c

asukaminato0721
asukaminato0721 commented Jun 25, 2020
View reviewed changes
Copy link
Copy Markdown
Author

@asukaminato0721 asukaminato0721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add one more blank line.

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 25, 2020

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 484d58a0-b6f6-11ea-bb0d-6965ce86ea0c

asukaminato0721
asukaminato0721 commented Jun 25, 2020
View reviewed changes
Copy link
Copy Markdown
Author

@asukaminato0721 asukaminato0721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete one blank line.

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 25, 2020

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 54857070-b6f7-11ea-bb0d-6965ce86ea0c

Delete one blank line.
b516227 
I've read the https://www.flake8rules.com/rules/W391.html, and still don't know how to do it. I've tried using 0 ,1,2 blank lines...
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Jun 25, 2020

Do not worry about Euler 47

asukaminato0721
asukaminato0721 commented Jun 25, 2020
View reviewed changes
Copy link
Copy Markdown
Author

@asukaminato0721 asukaminato0721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete one blank line.
Confused with this https://www.flake8rules.com/rules/W391.html

cclauss
cclauss reviewed Jun 25, 2020
View reviewed changes
cclauss
cclauss reviewed Jun 25, 2020
View reviewed changes
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 25, 2020

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1ffbf7a0-b6f9-11ea-bb0d-6965ce86ea0c

wuyudi and others added 2 commits June 25, 2020 23:33
@cclauss
Update graphs/bfs.py
39be6ba 
Co-authored-by: Christian Clauss <cclauss@me.com>
@cclauss
Update graphs/bfs.py
e523be6 
Co-authored-by: Christian Clauss <cclauss@me.com>
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 25, 2020

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a51fad50-b6f9-11ea-bb0d-6965ce86ea0c

@cclauss
Copy link
Copy Markdown
Member

cclauss commented Jun 25, 2020

We already have a breadth_first_search.py. Should this file be deleted??

@asukaminato0721
Copy link
Copy Markdown
Author

asukaminato0721 commented Jun 25, 2020

There are two different dfs files.
https://github.com/TheAlgorithms/Python/blob/master/graphs/depth_first_search.py
https://github.com/TheAlgorithms/Python/blob/master/graphs/depth_first_search_2.py
The same as these two bfs files.
https://github.com/TheAlgorithms/Python/blob/master/graphs/bfs.py
https://github.com/TheAlgorithms/Python/blob/master/graphs/breadth_first_search.py

@cclauss cclauss merged commit d2fa91b into TheAlgorithms:master Jun 25, 2020
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 25, 2020

Hey @wuyudi,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 4ac8aa20-b6fc-11ea-bb0d-6965ce86ea0c

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@cclauss @stokhos
Add url and typing hint for BFS (TheAlgorithms#2156)
86b1cf2 
* Add typing for bfs

* Add url for BFS

* rename the function

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update graphs/bfs.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Change the return value type of bfs

* change the function name.

change all instances of bfs() to breadth_first_search().

* change the function name in annotate

* Add one more blank line.

* Delete one blank line.

* Delete one blank line.

I've read the https://www.flake8rules.com/rules/W391.html, and still don't know how to do it. I've tried using 0 ,1,2 blank lines...

* Update graphs/bfs.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update graphs/bfs.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Rename bfs.py to breadth_first_search_2.py

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asukaminato0721 @TravisBuddy @cclauss