NLP Word Frequency Algorithms by danmurphy1217 · Pull Request #2142 · TheAlgorithms/Python

danmurphy1217 · 2020-06-21T16:15:44Z

Describe your change:

Add an algorithm? Added common NLP algorithms: term frequency, document frequency, and inverse document
frequency
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

l3str4nge

https://travis-ci.com/github/TheAlgorithms/Python/builds/172385776#L804

Please fix your code for passing unit tests for further review.

machine_learning/word_frequency_functions.py

Co-authored-by: Christian Clauss <cclauss@me.com>

TravisBuddy · 2020-06-22T21:28:20Z

Hey @danmurphy1217,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 49fd52f0-b4cf-11ea-bd89-f57d85bb28d1

TravisBuddy · 2020-06-22T21:48:47Z

Hey @danmurphy1217,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 25c1c850-b4d2-11ea-bd89-f57d85bb28d1

TravisBuddy · 2020-06-22T22:02:49Z

Travis tests have failed

Hey @danmurphy1217,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 017458d0-b4d4-11ea-bd89-f57d85bb28d1

TravisBuddy · 2020-06-22T22:52:44Z

Travis tests have failed

Hey @danmurphy1217,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 13ea6f70-b4db-11ea-bd89-f57d85bb28d1

TravisBuddy · 2020-06-23T01:00:52Z

Hey @danmurphy1217,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: fa991780-b4ec-11ea-bd89-f57d85bb28d1

TravisBuddy · 2020-06-23T01:18:39Z

Travis tests have failed

Hey @danmurphy1217,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 75e8dcc0-b4ef-11ea-bd89-f57d85bb28d1

cclauss · 2020-06-23T08:59:13Z

On your local machine, try: python3 -m doctest -v word_frequency_functions.py

TravisBuddy · 2020-06-23T15:46:05Z

Hey @danmurphy1217,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a49a18d0-b568-11ea-aae7-0b05fcc524af

danmurphy1217 · 2020-06-23T19:45:05Z

On your local machine, try: python3 -m doctest -v word_frequency_functions.py

Are there any other updates I should make?

machine_learning/word_frequency_functions.py

l3str4nge · 2020-06-23T22:37:07Z

machine_learning/word_frequency_functions.py

+        return idf
+    except ZeroDivisionError:
+        print("The term you searched for is not in the corpus.")
+


if raise this function not returning float

what do you mean? instead of print raise an error?

If error raised None will be returned. Is it good way? Wouldn't be better to check df value before calculation and raise error if df==0?. Also please add doctest with this situation.

Yes. Algorithm functions should not print as discussed in CONTRIBUTING.md. If our type hints promise that we will return a float then we should do so or raise an exception explaining why we can not do so.

machine_learning/word_frequency_functions.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* NLP Word Frequency Algorithms * Added type hints and Wikipedia link to tf-idf * Update machine_learning/word_frequency_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update machine_learning/word_frequency_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update machine_learning/word_frequency_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update machine_learning/word_frequency_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Fix line length for flake8 * Fix line length for flake8 V2 * Add line escapes and change int to float * Corrected doctests * Fix for TravisCI * Fix for TravisCI V2 * Tests passing locally * Tests passing locally * Update machine_learning/word_frequency_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update machine_learning/word_frequency_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update machine_learning/word_frequency_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Update machine_learning/word_frequency_functions.py Co-authored-by: Christian Clauss <cclauss@me.com> * Add doctest examples and clean up docstrings Co-authored-by: Christian Clauss <cclauss@me.com>

NLP Word Frequency Algorithms

24632d4

l3str4nge requested changes Jun 22, 2020

View reviewed changes

cclauss reviewed Jun 22, 2020

View reviewed changes

danmurphy1217 and others added 5 commits June 22, 2020 17:23

Added type hints and Wikipedia link to tf-idf

cbb5f41

Update machine_learning/word_frequency_functions.py

eb260b0

Co-authored-by: Christian Clauss <cclauss@me.com>

Update machine_learning/word_frequency_functions.py

e961f52

Co-authored-by: Christian Clauss <cclauss@me.com>

Update machine_learning/word_frequency_functions.py

e6b2357

Co-authored-by: Christian Clauss <cclauss@me.com>

Update machine_learning/word_frequency_functions.py

aa61ec8

Co-authored-by: Christian Clauss <cclauss@me.com>

danmurphy1217 added 2 commits June 22, 2020 17:44

Fix line length for flake8

bed579d

Fix line length for flake8

616087b

Fix line length for flake8 V2

9ef8e62

Add line escapes and change int to float

1152edd

danmurphy1217 added 2 commits June 22, 2020 20:27

Corrected doctests

e8890d6

Fix for TravisCI

bcbb8f6

Fix for TravisCI V2

a2628d4

Tests passing locally

a0bef59

Tests passing locally

4cd803a

l3str4nge requested changes Jun 23, 2020

View reviewed changes

cclauss reviewed Jun 24, 2020

View reviewed changes

machine_learning/word_frequency_functions.py Outdated Show resolved Hide resolved

cclauss reviewed Jun 24, 2020

View reviewed changes

machine_learning/word_frequency_functions.py Outdated Show resolved Hide resolved

cclauss reviewed Jun 24, 2020

View reviewed changes

machine_learning/word_frequency_functions.py Outdated Show resolved Hide resolved

cclauss reviewed Jun 24, 2020

View reviewed changes

machine_learning/word_frequency_functions.py Outdated Show resolved Hide resolved

danmurphy1217 and others added 6 commits June 24, 2020 15:37

Update machine_learning/word_frequency_functions.py

fcc07c9

Co-authored-by: Christian Clauss <cclauss@me.com>

Update machine_learning/word_frequency_functions.py

d35b5a6

Co-authored-by: Christian Clauss <cclauss@me.com>

Update machine_learning/word_frequency_functions.py

e901e09

Co-authored-by: Christian Clauss <cclauss@me.com>

Update machine_learning/word_frequency_functions.py

0a85c0f

Co-authored-by: Christian Clauss <cclauss@me.com>

Add doctest examples and clean up docstrings

fcef21e

Merge branch 'dan' of https://github.com/danmurphy1217/Python into dan

a0892e5

cclauss approved these changes Jun 25, 2020

View reviewed changes

l3str4nge approved these changes Jun 25, 2020

View reviewed changes

l3str4nge merged commit b368b1e into TheAlgorithms:master Jun 25, 2020

danmurphy1217 deleted the dan branch June 25, 2020 11:02

Uh oh!

Conversation

danmurphy1217 commented Jun 21, 2020

Describe your change:

Checklist:

Uh oh!

l3str4nge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TravisBuddy commented Jun 22, 2020

TravisBuddy Request Identifier: 49fd52f0-b4cf-11ea-bd89-f57d85bb28d1

Uh oh!

TravisBuddy commented Jun 22, 2020

TravisBuddy Request Identifier: 25c1c850-b4d2-11ea-bd89-f57d85bb28d1

Uh oh!

TravisBuddy commented Jun 22, 2020

Travis tests have failed

TravisBuddy Request Identifier: 017458d0-b4d4-11ea-bd89-f57d85bb28d1

Uh oh!

TravisBuddy commented Jun 22, 2020

Travis tests have failed

TravisBuddy Request Identifier: 13ea6f70-b4db-11ea-bd89-f57d85bb28d1

Uh oh!

TravisBuddy commented Jun 23, 2020

TravisBuddy Request Identifier: fa991780-b4ec-11ea-bd89-f57d85bb28d1

Uh oh!

TravisBuddy commented Jun 23, 2020

Travis tests have failed

TravisBuddy Request Identifier: 75e8dcc0-b4ef-11ea-bd89-f57d85bb28d1

Uh oh!

cclauss commented Jun 23, 2020

Uh oh!

TravisBuddy commented Jun 23, 2020

TravisBuddy Request Identifier: a49a18d0-b568-11ea-aae7-0b05fcc524af

Uh oh!

danmurphy1217 commented Jun 23, 2020

Uh oh!

Uh oh!

l3str4nge Jun 23, 2020

Choose a reason for hiding this comment

Uh oh!

danmurphy1217 Jun 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

l3str4nge Jun 24, 2020

Choose a reason for hiding this comment

Uh oh!

cclauss Jun 24, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

danmurphy1217 Jun 23, 2020 •

edited

Loading