Skip to content

implement rat in maze algorithm.#2106

Merged
cclauss merged 9 commits intoTheAlgorithms:masterfrom
beqakd:maze_problem
Jun 15, 2020
Merged

implement rat in maze algorithm.#2106
cclauss merged 9 commits intoTheAlgorithms:masterfrom
beqakd:maze_problem

Conversation

@beqakd
Copy link
Copy Markdown
Contributor

@beqakd beqakd commented Jun 12, 2020 •
edited
Loading

Describe your change:

implement rat in maze algorithm. #2103

  • Add an algorithm?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 12, 2020

Hey @beqakd,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d48eff90-acb9-11ea-8245-836d9da6cb4c

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 12, 2020

Hey @beqakd,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 534f3d00-acc8-11ea-8245-836d9da6cb4c

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 12, 2020

Hey @beqakd,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f045ee90-ace3-11ea-8245-836d9da6cb4c

@beqakd
Copy link
Copy Markdown
Contributor Author

beqakd commented Jun 12, 2020

Error is not from my pr. Style changes fixed.

cclauss
cclauss requested changes Jun 14, 2020
View reviewed changes
@beqakd
Copy link
Copy Markdown
Contributor Author

beqakd commented Jun 14, 2020 •
edited
Loading

Will do changes right ahead.

@beqakd
Copy link
Copy Markdown
Contributor Author

beqakd commented Jun 14, 2020

@cclauss All changes done. Also, tests added to each method. Thanks for points again.

@beqakd beqakd requested a review from cclauss June 14, 2020 13:56
cclauss
cclauss reviewed Jun 14, 2020
View reviewed changes
cclauss
cclauss reviewed Jun 14, 2020
View reviewed changes
cclauss
cclauss reviewed Jun 14, 2020
View reviewed changes
cclauss
cclauss reviewed Jun 14, 2020
View reviewed changes
cclauss
cclauss reviewed Jun 14, 2020
View reviewed changes
cclauss
cclauss reviewed Jun 14, 2020
View reviewed changes
cclauss
cclauss reviewed Jun 14, 2020
View reviewed changes
@beqakd
Copy link
Copy Markdown
Contributor Author

beqakd commented Jun 15, 2020

@cclauss done changes.

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 15, 2020

Travis tests have failed

Hey @beqakd,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 28c08610-af03-11ea-aad4-a340821c2822

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 15, 2020

Travis tests have failed

Hey @beqakd,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: dc8d7710-af04-11ea-aad4-a340821c2822

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 15, 2020

Hey @beqakd,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 439b9b30-af05-11ea-aad4-a340821c2822

@beqakd beqakd requested a review from cclauss June 15, 2020 12:54
cclauss
cclauss approved these changes Jun 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@cclauss cclauss merged commit 23dae9c into TheAlgorithms:master Jun 15, 2020
@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 15, 2020

Hey @beqakd,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: a328a310-af08-11ea-aad4-a340821c2822

@beqakd
Copy link
Copy Markdown
Contributor Author

beqakd commented Jun 15, 2020

Thanks for doing this.

Thanks for helping me out.

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@beqakd @cclauss @stokhos
implement rat in maze algorithm. (TheAlgorithms#2106)
8aa7bd7 
* implement rat in maze algorithm.

* style changes

* fix trailing whitespace

* add test, fix style

* fix style

* method change

* minor changes

* style changes

* return solved

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@beqakd @TravisBuddy @cclauss