Skip to content

implement sdbm hash algorithm#2094

Merged
cclauss merged 3 commits intoTheAlgorithms:masterfrom
bnMikheili:hash-sdbm
Jun 11, 2020
Merged

implement sdbm hash algorithm#2094
cclauss merged 3 commits intoTheAlgorithms:masterfrom
bnMikheili:hash-sdbm

Conversation

@bnMikheili
Copy link
Copy Markdown
Contributor

@bnMikheili bnMikheili commented Jun 11, 2020

PR implements easy to go hash algorithm sdbm

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 11, 2020

Hey @bnMikheili,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 5c1d4de0-ac10-11ea-a7dd-93c9ffbfb007

@TravisBuddy
Copy link
Copy Markdown

TravisBuddy commented Jun 11, 2020

Hey @bnMikheili,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 6c752720-ac11-11ea-a7dd-93c9ffbfb007

@bnMikheili
Copy link
Copy Markdown
Contributor Author

bnMikheili commented Jun 11, 2020

I had to fix conversions/decimal_to_any.py for tests to pass.

@cclauss cclauss merged commit ec2d900 into TheAlgorithms:master Jun 11, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@bnMikheili @stokhos
implement sdbm hash algorithm (TheAlgorithms#2094)
2ab7c4f 
* implement sdbm hash algorithm

* fix bug: styling

* fix styling for decimal_to_any
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bnMikheili @TravisBuddy @cclauss