Skip to content

Harris corner detection#2064

Merged
cclauss merged 13 commits intoTheAlgorithms:masterfrom
jeffin07:hcd
Jun 4, 2020
Merged

Harris corner detection#2064
cclauss merged 13 commits intoTheAlgorithms:masterfrom
jeffin07:hcd

Conversation

@jeffin07
Copy link
Copy Markdown
Contributor

@jeffin07 jeffin07 commented Jun 2, 2020

Describe your change:

Added Harris corner detection. #1809

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

vicky1999
vicky1999 approved these changes Jun 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vicky1999 vicky1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks for contributing

cclauss
cclauss requested changes Jun 2, 2020
View reviewed changes
TheSuperNoob
TheSuperNoob reviewed Jun 3, 2020
View reviewed changes
@jeffin07 jeffin07 requested a review from cclauss June 4, 2020 13:47
cclauss
cclauss approved these changes Jun 4, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for your contribution.

@cclauss cclauss merged commit 7a14285 into TheAlgorithms:master Jun 4, 2020
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Jun 4, 2020

I was a bit too fast in merging this. Do we really need a whole new directory for computer vision? Couldn't this instead fit somewhere in
https://github.com/TheAlgorithms/Python/tree/master/digital_image_processing ?

@jeffin07
Copy link
Copy Markdown
Contributor Author

jeffin07 commented Jun 4, 2020

I think Image processing and computer vision and little different from each other.Image processing means applying some algorithms for transforming image from one form to other like smoothing,contrasting, stretching etc While in computer vision comes from modelling image processing using the techniques of machine learning.Computer vision applies machine learning to recognize patterns for interpretation of images. Much like the process of visual reasoning of human vision

@jeffin07 jeffin07 deleted the hcd branch June 4, 2020 14:14
@poyea
Copy link
Copy Markdown
Member

poyea commented Jun 4, 2020

That's great. Feel free to open an issue, or create a readme inside the folder for description, just like the one in /bit_manipulation/.

@jeffin07
Copy link
Copy Markdown
Contributor Author

jeffin07 commented Jun 4, 2020

@poyea okay great. @cclauss what do you think ?

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@jeffin07 @cclauss @stokhos
Harris corner detection (TheAlgorithms#2064)
4d3fb5b 
* Added Lstm example for stock predection

* Changes after review

* changes after build failed

* Add Kiera’s to requirements.txt

* requirements.txt: Add keras and tensorflow

* psf/black

* haris corner detection

* fixup! Format Python code with psf/black push

* changes after review

* changes after review

* fixup! Format Python code with psf/black push

Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

+2 more reviewers

@TheSuperNoob TheSuperNoob TheSuperNoob left review comments

@vicky1999 vicky1999 vicky1999 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jeffin07 @cclauss @poyea @TheSuperNoob @vicky1999