Skip to content

circular_linked_list: Add more len() tests#2051

Merged
onlinejudge95 merged 6 commits intomasterfrom
circular_linked_list-len
May 31, 2020
Merged

circular_linked_list: Add more len() tests#2051
onlinejudge95 merged 6 commits intomasterfrom
circular_linked_list-len

Conversation

@cclauss
Copy link
Copy Markdown
Member

@cclauss cclauss commented May 31, 2020

Describe your change:

Add more len() and delete() tests

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Copy Markdown
Collaborator

@onlinejudge95 onlinejudge95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a check for black length required from my end

self.head = self.head.next_ptr

self.length -= 1
self.length -= 1
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

[(c1, c2) for c1, c2 in zip(matching_1, matching_2) if c1 != c2]
) // 2
transpositions = (
len([(c1, c2) for c1, c2 in zip(matching_1, matching_2) if c1 != c2]) // 2
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line has a length of 82 chars, is it below our threshold?

Copy link
Copy Markdown
Member Author

@cclauss cclauss May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black max_line_length is 88 characters.

@onlinejudge95 onlinejudge95 merged commit 1e8fe8e into master May 31, 2020
@onlinejudge95 onlinejudge95 deleted the circular_linked_list-len branch May 31, 2020 07:38
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* circular_linked_list: Add more len() tests

* fixup! Format Python code with psf/black push

* prepend()

* updating DIRECTORY.md

* Fix decrementation of self.length

* Add empty list tests

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants