refactor: move import pytest line of blockchain algs under "main" section.#2012
Merged
cclauss merged 6 commits intoTheAlgorithms:masterfrom May 19, 2020
allarobot:master
Merged
refactor: move import pytest line of blockchain algs under "main" section.#2012cclauss merged 6 commits intoTheAlgorithms:masterfrom allarobot:master
cclauss merged 6 commits intoTheAlgorithms:masterfrom
allarobot:master
Conversation
import doctest is not relevant with algorithms. move it under main section.
Member
|
For the commit message, please study how markdown check boxes work |
Contributor
Author
|
I did not check the fouth item of checklist, because there are multiple files with same improvement. Is it the reason why it failed? I don't understand the details of 'Travis CI - Pull Request checks' quite well. |
Contributor
Author
|
I got your point. I used the wrong mark to check the box. It has been revised. |
Member
|
The error that you are seeing was fixed in #2013 |
cclauss
approved these changes
May 19, 2020
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
…tion. (TheAlgorithms#2012) * change doctest line import doctest is not relevant with algorithms. move it under main section. * from doctest import testmod * refactor: move doctest under "main" section * Update diophantine_equation.py * Update modular_division.py Co-authored-by: Christian Clauss <cclauss@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
pytest package is not used by these algorithms. it is helpful when there is a need for testing.
it is reasonable to move these "import pytest" line of blockchain algs under "main" section.
Checklist:
Fixes: #{$ISSUE_NO}.