conversions/decimal_to_binary.py: Add type hints#2001
Merged
cclauss merged 4 commits intoTheAlgorithms:masterfrom Jun 2, 2020
Merged
conversions/decimal_to_binary.py: Add type hints#2001cclauss merged 4 commits intoTheAlgorithms:masterfrom
cclauss merged 4 commits intoTheAlgorithms:masterfrom
Conversation
cclauss
changed the title
cclauss
reviewed
May 18, 2020
|
|
||
|
|
||
| def decimal_to_binary(num): | ||
| def decimal_to_binary(num: int) -> str: |
Member
There was a problem hiding this comment.
It might be even cooler to actually return a binary number. i.e. 0b123 instead of "0b123".
cclauss
approved these changes
Jun 2, 2020
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* A .py file to covert a base to any new base(2-18) * Update base_changer.py * Added type-hints. * Delete base_changer.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.